From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JHPVI-0003Ns-JM for mharc-grub-devel@gnu.org; Tue, 22 Jan 2008 15:13:52 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JHPVG-0003NP-4R for grub-devel@gnu.org; Tue, 22 Jan 2008 15:13:50 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JHPVE-0003Mz-1k for grub-devel@gnu.org; Tue, 22 Jan 2008 15:13:49 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JHPVD-0003Mw-SV for grub-devel@gnu.org; Tue, 22 Jan 2008 15:13:47 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JHPVD-0001Df-I6 for grub-devel@gnu.org; Tue, 22 Jan 2008 15:13:47 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JHPVB-0003Gc-6h for grub-devel@gnu.org; Tue, 22 Jan 2008 21:13:46 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JHPTU-0005qt-1H for grub-devel@gnu.org; Tue, 22 Jan 2008 21:12:00 +0100 Date: Tue, 22 Jan 2008 21:12:00 +0100 From: Robert Millan To: grub-devel@gnu.org Message-ID: <20080122201200.GE21526@thorin> References: <20080120212034.GA2780@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20080120212034.GA2780@thorin> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] fix deadlock when probing USB deives on i386-ieee1275 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jan 2008 20:13:50 -0000 On Sun, Jan 20, 2008 at 10:20:34PM +0100, Robert Millan wrote: > > Fix deadlock when probing USB deives on i386-ieee1275. Detailed explanation > is in patch itself (C comment). > > Comments? > > -- > Robert Millan > > I know my rights; I want my phone call! > What use is a phone call… if you are unable to speak? > (as seen on /.) > > * disk/ieee1275/ofdisk.c (grub_ofdisk_iterate): When > `GRUB_IEEE1275_FLAG_OFDISK_SDCARD_ONLY' flag is set, skip any > device that doesn't look like an SD card. > * include/grub/ieee1275/ieee1275.h (grub_ieee1275_flag): Add > `GRUB_IEEE1275_FLAG_OFDISK_SDCARD_ONLY' flag. > * kern/powerpc/ieee1275/cmain.c (grub_ieee1275_set_flag): Detect > OLPC laptop, and set `GRUB_IEEE1275_FLAG_OFDISK_SDCARD_ONLY' when > found. Ok, seeing that nobody objects, I checked that in. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)