All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Remove BKL from sysctl(2)
Date: Tue, 22 Jan 2008 21:52:25 +0100	[thread overview]
Message-ID: <20080122205225.GD12892@elte.hu> (raw)
In-Reply-To: <20080122202727.GB1975@martell.zuzino.mipt.ru>


* Alexey Dobriyan <adobriyan@gmail.com> wrote:

> /proc/sys part of sysctl code runs without BKL held, so BKL during 
> sysctl(2) is useless. Remove misleading comment and "protection" 
> around coredumping code -- kernel.core_pattern can be written without 
> BKL.
> 
> do_sysctl() and lookup in /proc/sys use identical iterators, so any 
> locking bug BKL supposedly fixed in sysctl(2) code we should have in 
> /proc/sys code anyway.
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>

cool! You just shortened the grand 10-year-plan of BKL removal by at 
least one year :-)

Acked-by: Ingo Molnar <mingo@elte.hu>

	Ingo

  reply	other threads:[~2008-01-22 20:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-22 20:27 [PATCH] Remove BKL from sysctl(2) Alexey Dobriyan
2008-01-22 20:52 ` Ingo Molnar [this message]
2008-01-23 10:51 ` Alan Cox
2008-01-23 11:09   ` Andi Kleen
2008-01-23 11:38     ` Alan Cox
2008-01-24  7:56       ` Andi Kleen
2008-01-27 12:26   ` [PATCH 2/2] Race-free kernel.core_pattern Alexey Dobriyan
2008-01-27 16:49     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080122205225.GD12892@elte.hu \
    --to=mingo@elte.hu \
    --cc=adobriyan@gmail.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.