From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JHdeB-0005AE-9w for mharc-grub-devel@gnu.org; Wed, 23 Jan 2008 06:19:59 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JHde9-00058x-JZ for grub-devel@gnu.org; Wed, 23 Jan 2008 06:19:57 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JHde8-00057U-W7 for grub-devel@gnu.org; Wed, 23 Jan 2008 06:19:57 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JHde8-00057N-Pc for grub-devel@gnu.org; Wed, 23 Jan 2008 06:19:56 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JHde8-0005K5-Ia for grub-devel@gnu.org; Wed, 23 Jan 2008 06:19:56 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JHde7-00053l-81 for grub-devel@gnu.org; Wed, 23 Jan 2008 12:19:55 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JHdcc-0006p8-Ge for grub-devel@gnu.org; Wed, 23 Jan 2008 12:18:22 +0100 Date: Wed, 23 Jan 2008 12:18:22 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080123111822.GC25594@thorin> References: <20080123104737.GA24943@thorin> <87wsq0reod.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87wsq0reod.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] use at_keyboard.c on i386-ieee1275 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jan 2008 11:19:57 -0000 On Wed, Jan 23, 2008 at 11:58:58AM +0100, Marco Gerards wrote: > Robert Millan writes: > > > Taking into account that ofconsole on i386: > > > > - Has bugs with similar usability effect than at_keyboard.c (e.g. arrow keys > > not working). > > - In practice doesn't provide support for any keyboard other than AT > > (since OFW shuts down USB before transfering control to us). > > - Sharing code with other ports (CoreBoot, attow) is more efficient to get > > these bugs solved. > > > > I propose to use at_keyboard.c as default for i386-ieee1275. > > Fine for me, it is your baby :-) Although you forgot the changelog entry. * conf/i386-ieee1275.rmk (kernel_elf_SOURCES): Add `term/i386/pc/at_keyboard.c'. * include/grub/i386/ieee1275/console.h: Add `'. Remove `'. (grub_keyboard_controller_init): New function prototype. (grub_console_checkkey): Likewise. (grub_console_getkey): Likewise. * kern/powerpc/ieee1275/init.c (grub_machine_init): Initialize AT keyboard on i386. * term/ieee1275/ofconsole.c (grub_ofconsole_term): On i386, use grub_ofconsole_checkkey() and grub_ofconsole_getkey() for input. > Will you fix the ifdef's soon? My plan is to propose a split of terminal handling in kernel so that input and output terminals become different objects. This would fix this hack and others (such as intermangled at_keyboard.c/vga_text.c with console.c in CB port, or gfxterm depending on grub_console_{get,check}key() ). But I'd like to leave this for later. As mentioned on IRC, Debian is planning to start stabilizing next release in March. If GRUB 2 is mostly in shape at that time, we'll be able to use it as the default bootloader. Which reminds me, is 1.96 coming soon? When lvm/raid, reiserfs and powerpc issues are fixed, it might be a good time. What do you think? > Doesn't this cause any problems? Now there are two keyboard drivers > active. Not at all. I didn't bother #ifdefing grub_ofconsole_{get,check}key out to avoid cluttering it (since space is not critical), but it works fine here. The only drawback is that it doesn't automaticaly switch to serial tty when OFW is running there, but that's a problem for every other port anyway (I have a solution in mind as well; when we redesign terminal handling, we could layout a scheme in which multiple input or output terminals can be active at the same time). -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)