From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JHdiZ-00025j-W6 for mharc-grub-devel@gnu.org; Wed, 23 Jan 2008 06:24:32 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JHdiY-00025F-HG for grub-devel@gnu.org; Wed, 23 Jan 2008 06:24:30 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JHdiW-000250-5a for grub-devel@gnu.org; Wed, 23 Jan 2008 06:24:29 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JHdiW-00024x-0E for grub-devel@gnu.org; Wed, 23 Jan 2008 06:24:28 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JHdiV-0006at-PA for grub-devel@gnu.org; Wed, 23 Jan 2008 06:24:27 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JHdiU-000540-IY for grub-devel@gnu.org; Wed, 23 Jan 2008 12:24:27 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JHdh3-0006ry-Ux for grub-devel@gnu.org; Wed, 23 Jan 2008 12:22:57 +0100 Date: Wed, 23 Jan 2008 12:22:57 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080123112257.GD25594@thorin> References: <20080116031949.qvrrwl9868o4cwsc@webmail.spamcop.net> <87sl0ore9e.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87sl0ore9e.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Running GRUB under qemu on PowerPC X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jan 2008 11:24:30 -0000 On Wed, Jan 23, 2008 at 12:07:57PM +0100, Marco Gerards wrote: > Pavel Roskin writes: > > Hi, > > [...] > > > ChangeLog: > > > > * include/grub/ieee1275/ieee1275.h: Introduce a flag for > > broken color support, needed for Open Hack'Ware. > > * kern/powerpc/ieee1275/cmain.c (grub_ieee1275_find_options): > > Recognize Open Hack'Ware. > > * term/ieee1275/ofconsole.c (grub_ofconsole_init): Skip color > > initialization for Open Hack'Ware. > > This looks fine to me. Robert, what do you think about this patch > specifically? I see no reason why this can't be committed, but I am > not working on the PPC port lately. It looks mostly fine to me. I have 3 suggestions: > + if (! grub_ieee1275_finddevice ("/rom/boot-rom", &bootrom)) { > + rc = grub_ieee1275_get_property (bootrom, "model", > + tmp, sizeof (tmp), 0); > +#define OHW "PPC Open Hack'Ware" > + if (rc >= 0 && !grub_strncmp (tmp, OHW, sizeof (OHW) - 1)) { I think it's better to #undef OHW after using it, just in case. > - /* Set the right fg and bg colors. */ > - grub_ofconsole_setcolorstate (GRUB_TERM_COLOR_NORMAL); > + if (! grub_ieee1275_test_flag (GRUB_IEEE1275_FLAG_BROKEN_COLORS)) { Perhaps GRUB_IEEE1275_FLAG_BROKEN_COLORS could be made more descriptive (in the future we might find other, new, amusing ways in which colors can break! :-)). How about GRUB_IEEE1275_FLAG_CANNOT_SET_COLORS ? Also, GRUB code style puts a newline before opening brackets. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)