From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JHe2U-0006W2-Jj for mharc-grub-devel@gnu.org; Wed, 23 Jan 2008 06:45:06 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JHe2S-0006VY-UN for grub-devel@gnu.org; Wed, 23 Jan 2008 06:45:04 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JHe2Q-0006VM-EV for grub-devel@gnu.org; Wed, 23 Jan 2008 06:45:03 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JHe2Q-0006VJ-9x for grub-devel@gnu.org; Wed, 23 Jan 2008 06:45:02 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JHe2Q-0003lg-26 for grub-devel@gnu.org; Wed, 23 Jan 2008 06:45:02 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JHe2O-00055J-IJ for grub-devel@gnu.org; Wed, 23 Jan 2008 12:45:01 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JHe0x-00074Y-KC for grub-devel@gnu.org; Wed, 23 Jan 2008 12:43:31 +0100 Date: Wed, 23 Jan 2008 12:43:31 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080123114331.GA27060@thorin> References: <20071103230631.GA2875@boeglin.org> <87hcjuhzo8.fsf@xs4all.nl> <20071118181403.GA11941@boeglin.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20071118181403.GA11941@boeglin.org> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: grub2 efi patches X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jan 2008 11:45:05 -0000 On Sun, Nov 18, 2007 at 07:14:03PM +0100, Alexandre Boeglin wrote: > Index: commands/i386/efi/halt.c > =================================================================== > RCS file: commands/i386/efi/halt.c > diff -N commands/i386/efi/halt.c > [...] > +static grub_err_t > +grub_cmd_halt (struct grub_arg_list *state __attribute__ ((unused)), > + int argc __attribute__ ((unused)), > + char **args __attribute__ ((unused))) > + > +{ > + grub_halt (); > + return 0; > +} > + > + > + > +GRUB_MOD_INIT(halt) > +{ > + (void)mod; /* To stop warning. */ > + grub_register_command ("halt", grub_cmd_halt, GRUB_COMMAND_FLAG_BOTH, > + "halt", "Halt the computer", 0); > +} > + > +GRUB_MOD_FINI(halt) > +{ > + grub_unregister_command ("halt"); > +} commands/ieee1275/halt.c looks like the same thing to me. Perhaps it'd make more sense to move that to commands/halt.c and use it as the "generic" version of halt command? > Index: commands/i386/efi/reboot.c > =================================================================== > RCS file: commands/i386/efi/reboot.c > diff -N commands/i386/efi/reboot.c > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ commands/i386/efi/reboot.c 18 Nov 2007 17:49:37 -0000 Possibly the same applies here. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)