From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JHeFA-0002y7-Fn for mharc-grub-devel@gnu.org; Wed, 23 Jan 2008 06:58:12 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JHeF9-0002x6-1H for grub-devel@gnu.org; Wed, 23 Jan 2008 06:58:11 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JHeF7-0002ub-2V for grub-devel@gnu.org; Wed, 23 Jan 2008 06:58:10 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JHeF6-0002uQ-UG for grub-devel@gnu.org; Wed, 23 Jan 2008 06:58:08 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JHeF6-0007zw-JJ for grub-devel@gnu.org; Wed, 23 Jan 2008 06:58:08 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JHeF0-000560-29 for grub-devel@gnu.org; Wed, 23 Jan 2008 12:58:02 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JHeDK-0000Bm-Ty for grub-devel@gnu.org; Wed, 23 Jan 2008 12:56:18 +0100 Date: Wed, 23 Jan 2008 12:56:18 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080123115618.GE27060@thorin> References: <20080123104737.GA24943@thorin> <87wsq0reod.fsf@xs4all.nl> <20080123111822.GC25594@thorin> <87fxword4x.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87fxword4x.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] use at_keyboard.c on i386-ieee1275 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jan 2008 11:58:11 -0000 On Wed, Jan 23, 2008 at 12:32:14PM +0100, Marco Gerards wrote: > > * conf/i386-ieee1275.rmk (kernel_elf_SOURCES): Add > > `term/i386/pc/at_keyboard.c'. > > > > * include/grub/i386/ieee1275/console.h: Add `'. Remove > > `'. > > (grub_keyboard_controller_init): New function prototype. > > (grub_console_checkkey): Likewise. > > (grub_console_getkey): Likewise. > > > > * kern/powerpc/ieee1275/init.c (grub_machine_init): Initialize AT > > keyboard on i386. > > > > * term/ieee1275/ofconsole.c (grub_ofconsole_term): On i386, use > > grub_ofconsole_checkkey() and grub_ofconsole_getkey() for input. > > Looks fine to me. Done. I also enabled serial.mod. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)