From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JHfM4-0002SM-7x for mharc-grub-devel@gnu.org; Wed, 23 Jan 2008 08:09:24 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JHfM2-0002S8-D3 for grub-devel@gnu.org; Wed, 23 Jan 2008 08:09:22 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JHfM1-0002Rv-1n for grub-devel@gnu.org; Wed, 23 Jan 2008 08:09:22 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JHfM0-0002Rs-Rp for grub-devel@gnu.org; Wed, 23 Jan 2008 08:09:20 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JHfM0-0005LO-QA for grub-devel@gnu.org; Wed, 23 Jan 2008 08:09:20 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JHfLx-0005Bn-Qn for grub-devel@gnu.org; Wed, 23 Jan 2008 14:09:19 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JHfKJ-0007ZZ-PJ for grub-devel@gnu.org; Wed, 23 Jan 2008 14:07:35 +0100 Date: Wed, 23 Jan 2008 14:07:35 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080123130735.GA29078@thorin> References: <20071223210936.GA27776@thorin> <20071224012818.GA22510@thorin> <20071224013530.GA22710@thorin> <4776DD49.7030406@nic.fi> <87lk6gpw6f.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87lk6gpw6f.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: gfxterm / grub_virtual_screen_setcolorstate() X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jan 2008 13:09:22 -0000 On Wed, Jan 23, 2008 at 01:23:52PM +0100, Marco Gerards wrote: > Vesa Jääskeläinen writes: > > > Robert Millan wrote: > >> On Mon, Dec 24, 2007 at 02:28:18AM +0100, Robert Millan wrote: > >>> New patch. Corrects a minor mistake when filling the last colum in the > >>> menu. Also, it doesn't change the colors on gfxterm since some reasjustments > >>> were needed for that, and there's also a bug that makes it impossible to > >>> change colors on the fly with gfxterm/vbe (I'll write more on that later). > >> > >> This patch (relative to previous one) basicaly makes it work with a big > >> ugly kludge (see "| 0xff000000" line). The problem seems to be that alpha > >> channel is set to 0 for all return values of grub_video_map_color() after > >> gfxterm initialization. I checked the few places in the code where those > >> variables are zeroed, but to no avail. I assume the problem is just they > >> haven't been initialised, but I just have no idea where they're supposed to. > >> > >> Any clues? > > > > Ok... Your "fix" with OR'ing is not a good one as that makes an > > assumption about display mode settings. Idea of mapping colors is to get > > most optimal color settings for desired video mode. Nevertheless I think > > I know the problem and I get back to you shortly... now I sleep :) > > > > That zero alpha setting most likely comes from color table being > > specified. (or from video mode settings currently in use, eg. no > > alpha/reserved bits) > > This was fixed already? Vesa fixed it. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)