From: Andrew Morton <akpm@linux-foundation.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: linux-kernel@vger.kernel.org, knikanth@novell.com, jens.axboe@oracle.com
Subject: Re: [PATCH 2/6] io context sharing: preliminary support
Date: Wed, 23 Jan 2008 14:08:03 -0800 [thread overview]
Message-ID: <20080123140803.ff320a96.akpm@linux-foundation.org> (raw)
In-Reply-To: <1200995361-24001-3-git-send-email-jens.axboe@oracle.com>
> On Tue, 22 Jan 2008 10:49:17 +0100 Jens Axboe <jens.axboe@oracle.com> wrote:
> -void put_io_context(struct io_context *ioc)
> +int put_io_context(struct io_context *ioc)
> {
> if (ioc == NULL)
> - return;
> + return 1;
>
> BUG_ON(atomic_read(&ioc->refcount) == 0);
>
> @@ -3856,7 +3856,9 @@ void put_io_context(struct io_context *ioc)
> rcu_read_unlock();
>
> kmem_cache_free(iocontext_cachep, ioc);
> + return 1;
> }
> + return 0;
> }
Document the return value? (and the function)
I assume this return value gets used in some other patch.
next prev parent reply other threads:[~2008-01-23 22:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-22 9:49 [PATCH 0/6] IO context sharing Jens Axboe
2008-01-22 9:49 ` [PATCH 1/6] ioprio: move io priority from task_struct to io_context Jens Axboe
2008-01-23 22:07 ` Andrew Morton
2008-01-24 7:30 ` Jens Axboe
2008-01-22 9:49 ` [PATCH 2/6] io context sharing: preliminary support Jens Axboe
2008-01-23 22:08 ` Andrew Morton [this message]
2008-01-24 7:36 ` Jens Axboe
2008-01-22 9:49 ` [PATCH 3/6] io_context sharing - cfq changes Jens Axboe
2008-01-22 9:49 ` [PATCH 4/6] block: cfq: make the io contect sharing lockless Jens Axboe
2008-01-23 22:08 ` Andrew Morton
2008-01-24 7:36 ` Jens Axboe
2008-01-24 16:42 ` Paul E. McKenney
2008-01-22 9:49 ` [PATCH 5/6] io_context sharing - anticipatory changes Jens Axboe
2008-01-22 9:49 ` [PATCH 6/6] kernel: add CLONE_IO to specifically request sharing of IO contexts Jens Axboe
2008-01-22 14:49 ` [PATCH 0/6] IO context sharing Peter Zijlstra
2008-01-22 18:21 ` Jens Axboe
2008-01-23 3:50 ` David Chinner
2008-01-23 8:44 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080123140803.ff320a96.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jens.axboe@oracle.com \
--cc=knikanth@novell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.