From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JHh14-0006PZ-8P for mharc-grub-devel@gnu.org; Wed, 23 Jan 2008 09:55:50 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JHh11-0006NN-RM for grub-devel@gnu.org; Wed, 23 Jan 2008 09:55:47 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JHh0z-0006Kf-EP for grub-devel@gnu.org; Wed, 23 Jan 2008 09:55:46 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JHh0z-0006KR-73 for grub-devel@gnu.org; Wed, 23 Jan 2008 09:55:45 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JHh0y-00039I-O9 for grub-devel@gnu.org; Wed, 23 Jan 2008 09:55:44 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JHh0v-0005MA-Hw for grub-devel@gnu.org; Wed, 23 Jan 2008 15:55:43 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JHgz7-0008Og-T7 for grub-devel@gnu.org; Wed, 23 Jan 2008 15:53:49 +0100 Date: Wed, 23 Jan 2008 15:53:49 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080123145349.GA32203@thorin> References: <20080123132318.GA29666@thorin> <87sl0oocwk.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87sl0oocwk.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] loader cleanup for i386-ieee1275 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jan 2008 14:55:48 -0000 On Wed, Jan 23, 2008 at 03:05:31PM +0100, Marco Gerards wrote: > Robert Millan writes: > > > Some cleanup for i386-ieee1275. > > Can you please give a bit more information? The multiboot module on i386-ieee1275 was using variables that only have a meaning on i386-pc (and i386-linuxbios): grub_os_area_addr, grub_os_area_size, grub_lower_mem and grub_upper_mem. A bunch of unnecessary cruft from i386-pc port was being included, because at the beginning I thought I would base the multiboot loader on i386-pc (like I did for i386-linuxbios), but this turned out to be a wrong approach. > > * include/grub/i386/ieee1275/loader.h: Include `', > > `' and `'. > > (grub_multiboot2_real_boot): New function prototype. > > > > * include/grub/i386/pc/memory.h: Include `'. > > (grub_lower_mem, grub_upper_mem): Disable for IEEE1275. > > You can make this conditional in the ChangeLog entry. What do you mean? -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)