From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Thibault Subject: Re: ioemu: empty vnc passwd Date: Wed, 23 Jan 2008 16:58:57 +0000 Message-ID: <20080123165857.GP4252@implementation.uk.xensource.com> References: <20080123161130.GD5188@implementation.uk.xensource.com> <200801231719.34142.Christoph.Egger@amd.com> <20080123162811.GE24352@redhat.com> <20080123164233.GM4252@implementation.uk.xensource.com> <20080123165015.GB17258@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20080123165015.GB17258@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Daniel P. Berrange" Cc: Christoph Egger , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Daniel P. Berrange, le Wed 23 Jan 2008 16:50:15 +0000, a écrit : > On Wed, Jan 23, 2008 at 04:42:33PM +0000, Samuel Thibault wrote: > > Daniel P. Berrange, le Wed 23 Jan 2008 16:28:11 +0000, a écrit : > > > VNC password authentication is turned on / off via the ',passwd' flag on > > > the -vnc command line to QEMU. If password auth is on, and a zero length > > > string is found as a password, then all logins are completely disabled - > > > the VNC password auth code will fail all logins. If passwd auth is off on > > > the command line, then any password stored in xenstore is irrelevant, no > > > matter what length it is. > > > > Ok, so the real fix seems to be to take that flag into account (which is > > not the case currently). > > Urm, its already processed. See vnc_display_open() in tools/ioemu/vnc.c Yes, but that doesn't prevent the exit() when the passwd can't be read from XenStore. Samuel