Re: [PATCH 01/20 -v5] printk - dont wakeup klogd with interrupts disabled

[Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>]

* Daniel Walker (dwalker@mvista.com) wrote:
> 
> On Wed, 2008-01-23 at 11:02 -0500, Steven Rostedt wrote:
> 
> > +	if (!irqs_disabled() && wake_klogd)
> >  		wake_up_klogd();
> 
> This causes a regression .. When printk is called during an OOPS in
> kernels without this change then the OOPS will get logged, since the
> logging process (klogd) is woken to handle the messages.. If you apply
> this change klogd doesn't wakeup, and hence doesn't log the oops.. So if
> you remove the wakeup here you have to add it someplace else to maintain
> the logging ..
> 
> (I'm not theorizing here, I have defects logged against this specific
> piece of code..)
> 

Can we change this for :
if (!(irqs_disabled() && !oops_in_progress) && wake_klogd)
  wake_up_klogd();

?

(totally untested)

> Daniel
> 

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68