From: Len Brown <lenb@kernel.org>
To: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: linux-acpi@vger.kernel.org
Subject: Re: [PATCH 8/8] ACPI: DMI blacklist to reduce console warnings on OSI(Linux) systems.
Date: Wed, 23 Jan 2008 23:35:03 -0500 [thread overview]
Message-ID: <200801232335.03453.lenb@kernel.org> (raw)
In-Reply-To: <200801240255.15294.carlos@strangeworlds.co.uk>
On Wednesday 23 January 2008 21:55, Carlos Corbacho wrote:
> Why not just match on:
>
> > + .ident = "Acer",
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
> > + },
> > + },
>
> for all Acer laptops?
hmmm, because I assumed that dmi_check_system()
would do an exact string compare with "!strcmp()".
I'm surprised to discover it uses strstr() and matches
substrings instead. Is there logic behind that?
Certainly it makes using a single entry to match
a vendor problematic, as a short vendor string
could potentially be a substring of a different (unknown) vendor...
-Len
next prev parent reply other threads:[~2008-01-24 4:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-24 2:32 deal with OSI(Linux) (v2) Len Brown
2008-01-24 2:32 ` [PATCH 1/8] DMI: move dmi_available declaration to linux/dmi.h Len Brown
2008-01-24 2:32 ` [PATCH 2/8] DMI: create dmi_get_slot() Len Brown
2008-01-24 2:32 ` [PATCH 3/8] ACPI: create acpi_dmi_dump() Len Brown
2008-01-24 2:32 ` [PATCH 4/8] ACPI: on OSI(Linux), print needed DMI rather than requesting dmidecode output Len Brown
2008-01-24 2:32 ` [PATCH 5/8] ACPI: Delete Intel Customer Reference Board (CRB) from OSI(Linux) DMI list Len Brown
2008-01-24 2:32 ` [PATCH 6/8] ACPI: make _OSI(Linux) console messages smarter Len Brown
2008-01-24 2:32 ` [PATCH 7/8] ACPI: Add ThinkPad R61, ThinkPad T61 to OSI(Linux) white-list Len Brown
2008-01-24 2:32 ` [PATCH 8/8] ACPI: DMI blacklist to reduce console warnings on OSI(Linux) systems Len Brown
2008-01-24 2:55 ` Carlos Corbacho
2008-01-24 4:35 ` Len Brown [this message]
2008-01-24 4:54 ` Carlos Corbacho
2008-01-25 20:36 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801232335.03453.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=carlos@strangeworlds.co.uk \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.