All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Abhishek Rai <abhishekrai@google.com>
Cc: linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org,
	rohitseth@google.com
Subject: Re: [CALL FOR TESTING] Make Ext3 fsck way faster [2.6.24-rc6 -mm patch]
Date: Wed, 23 Jan 2008 23:49:05 -0800	[thread overview]
Message-ID: <20080123234905.35664ed6.akpm@linux-foundation.org> (raw)
In-Reply-To: <200801230412.16992.abhishekrai@google.com>

> On Wed, 23 Jan 2008 04:12:16 -0500 Abhishek Rai <abhishekrai@google.com> wrote:
> > I'm wondering about the interaction between this code and the
> > buffer_boundary() logic.  I guess we should disable the buffer_boundary()
> > handling when this code is in effect.  Have you reviewed and tested that
> > aspect?
> 
> Thanks for pointing this out, I had totally missed this issue in my change. I've now made the call to set_buffer_boundary() in ext3_get_blocks_handle() subject to metacluster option being set.
> 

Did it make any performance difference?  iirc the buffer_boundary stuff was
worth around 10% on a single linear read of a large, well-laid-out file.

  reply	other threads:[~2008-01-24  7:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-23  9:12 [CALL FOR TESTING] Make Ext3 fsck way faster [2.6.24-rc6 -mm patch] Abhishek Rai
2008-01-24  7:49 ` Andrew Morton [this message]
2008-01-24 13:14   ` Abhishek Rai
  -- strict thread matches above, loose matches on Subject: below --
2008-01-14 13:39 Abhishek Rai
2008-01-15  0:34 ` Andrew Morton
2008-01-15 11:04   ` Andrew Morton
2008-01-15 13:15     ` Christoph Hellwig
2008-01-15 13:16       ` Christoph Hellwig
2008-01-15 15:28       ` Theodore Tso
2008-01-17 12:47         ` Abhishek Rai
2008-01-17 12:47           ` Abhishek Rai
2008-01-20  4:10           ` Daniel Phillips
2008-01-21  2:51             ` Theodore Tso
2008-01-24 19:04               ` Daniel Phillips
2008-01-15 15:09     ` Ric Wheeler
2008-01-16  5:08       ` Valdis.Kletnieks
2008-01-16  4:25     ` Valdis.Kletnieks
2008-01-17 11:36       ` Andreas Dilger
2008-01-20  3:55     ` Daniel Phillips
2008-01-13  5:47 Abhishek Rai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080123234905.35664ed6.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=abhishekrai@google.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rohitseth@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.