From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JHpcx-0000wT-15 for mharc-grub-devel@gnu.org; Wed, 23 Jan 2008 19:07:31 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JHpct-0000s2-Q2 for grub-devel@gnu.org; Wed, 23 Jan 2008 19:07:27 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JHpcs-0000pe-12 for grub-devel@gnu.org; Wed, 23 Jan 2008 19:07:27 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JHpcr-0000pO-Ru for grub-devel@gnu.org; Wed, 23 Jan 2008 19:07:25 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JHpcr-0004of-Fr for grub-devel@gnu.org; Wed, 23 Jan 2008 19:07:25 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JHpcq-0006C3-BN for grub-devel@gnu.org; Thu, 24 Jan 2008 01:07:24 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JHpbE-00009v-UL for grub-devel@gnu.org; Thu, 24 Jan 2008 01:05:44 +0100 Date: Thu, 24 Jan 2008 01:05:44 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080124000544.GB32503@thorin> References: <94a0ccbc0801231500g752f72acodc37c733726d8919@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <94a0ccbc0801231500g752f72acodc37c733726d8919@mail.gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: /kern/file.c BUG X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jan 2008 00:07:28 -0000 On Wed, Jan 23, 2008 at 11:00:57PM +0000, Oleg Strikov wrote: > Incorrect behavior of grub_file_open () function in e.g. loop context: > > char *file_names[] = > { > "(hd0,1)/file1", //file do not exist > "(hd0,1)/file2" //file exist > }; > grub_file_t file; > int i; > for (i = 0; i < 2; i++) > { > file = grub_file_open (file_names[i]); > if (file) {...} > } > > There, we should get positive return in the second case (i == 1), but > grub_file_open() returns 0. > > Using gdb i've found that this problem connected with incorrect errno check > in /kern/file.c > > Let's look: > > >grub_file_t > >grub_file_open (const char *name) > >{ > > grub_device_t device; > > grub_file_t file = 0; > > char *device_name; > > char *file_name; > > > device_name = grub_file_get_device_name (name); > > if (grub_errno) > > return 0; > > But, we DO NOT set grub_errno to 0 at the begining of the function, thats > why next loop round it always returns 0 Fixed, thank you. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)