From: Chandra Seetharaman <sekharan@us.ibm.com>
To: dm-devel@redhat.com, linux-scsi@vger.kernel.org
Cc: andmike@us.ibm.com, michaelc@cs.wisc.edu,
Chandra Seetharaman <sekharan@us.ibm.com>,
jens.axboe@oracle.com
Subject: [PATCH 2/9] scsi_dh: change sd_prep_fn to call common code
Date: Wed, 23 Jan 2008 16:30:42 -0800 [thread overview]
Message-ID: <20080124003042.18871.69006.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20080124003010.18871.84095.sendpatchset@localhost.localdomain>
Subject: scsi_dh: change sd_prep_fn to call common code
From: Mike Anderson <andmike@linux.vnet.ibm.com>
Have sd_prep_fn call common code if not REQ_TYPE_FS.
Signed-off-by: Mike Anderson <andmike@linux.vnet.ibm.com>
Signed-off-by: Chandra Seetharaman <sekharan@us.ibm.com>
---
drivers/scsi/scsi_lib.c | 1 1 + 0 - 0 !
drivers/scsi/sd.c | 9 2 + 7 - 0 !
include/scsi/scsi_driver.h | 1 1 + 0 - 0 !
3 files changed, 4 insertions(+), 7 deletions(-)
Index: linux-2.6.24-rc8/drivers/scsi/scsi_lib.c
===================================================================
--- linux-2.6.24-rc8.orig/drivers/scsi/scsi_lib.c
+++ linux-2.6.24-rc8/drivers/scsi/scsi_lib.c
@@ -1334,6 +1334,7 @@ int scsi_prep_fn(struct request_queue *q
ret = scsi_setup_blk_pc_cmnd(sdev, req);
return scsi_prep_return(q, req, ret);
}
+EXPORT_SYMBOL(scsi_prep_fn);
/*
* scsi_dev_queue_ready: if we can send requests to sdev, return 1 else
Index: linux-2.6.24-rc8/drivers/scsi/sd.c
===================================================================
--- linux-2.6.24-rc8.orig/drivers/scsi/sd.c
+++ linux-2.6.24-rc8/drivers/scsi/sd.c
@@ -354,13 +354,8 @@ static int sd_prep_fn(struct request_que
unsigned int timeout = sdp->timeout;
int ret;
- if (rq->cmd_type == REQ_TYPE_BLOCK_PC) {
- ret = scsi_setup_blk_pc_cmnd(sdp, rq);
- goto out;
- } else if (rq->cmd_type != REQ_TYPE_FS) {
- ret = BLKPREP_KILL;
- goto out;
- }
+ if (rq->cmd_type != REQ_TYPE_FS)
+ return scsi_prep_fn(q, rq);
ret = scsi_setup_fs_cmnd(sdp, rq);
if (ret != BLKPREP_OK)
goto out;
Index: linux-2.6.24-rc8/include/scsi/scsi_driver.h
===================================================================
--- linux-2.6.24-rc8.orig/include/scsi/scsi_driver.h
+++ linux-2.6.24-rc8/include/scsi/scsi_driver.h
@@ -32,5 +32,6 @@ int scsi_setup_blk_pc_cmnd(struct scsi_d
int scsi_setup_fs_cmnd(struct scsi_device *sdev, struct request *req);
int scsi_prep_state_check(struct scsi_device *sdev, struct request *req);
int scsi_prep_return(struct request_queue *q, struct request *req, int ret);
+int scsi_prep_fn(struct request_queue *q, struct request *req);
#endif /* _SCSI_SCSI_DRIVER_H */
--
----------------------------------------------------------------------
Chandra Seetharaman | Be careful what you choose....
- sekharan@us.ibm.com | .......you may get it.
----------------------------------------------------------------------
next prev parent reply other threads:[~2008-01-24 0:30 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-24 0:30 [PATCH 0/9] scsi_dh: Move dm device handler to SCSI layer Chandra Seetharaman
2008-01-24 0:30 ` [PATCH 1/9] scsi_dh: add REQ_LB_OP_TRANSITION and errors Chandra Seetharaman
2008-01-24 0:30 ` Chandra Seetharaman [this message]
2008-01-24 0:30 ` [PATCH 3/9] scsi_dh: scsi handling of REQ_LB_OP_TRANSITION Chandra Seetharaman
2008-02-01 20:00 ` Mike Christie
2008-02-04 18:59 ` Chandra Seetharaman
2008-02-04 19:02 ` James Bottomley
2008-02-06 19:00 ` Mike Anderson
2008-02-06 20:52 ` James Bottomley
2008-01-24 0:31 ` [PATCH 4/9] scsi_dh: add skeleton for SCSI Device Handlers Chandra Seetharaman
2008-02-01 19:53 ` Mike Christie
2008-02-01 20:27 ` Mike Anderson
2008-02-04 18:54 ` Chandra Seetharaman
2008-01-24 0:31 ` [PATCH 5/9] scsi_dh: add EMC Clariion device handler Chandra Seetharaman
2008-01-24 0:31 ` [PATCH 6/9] scsi_dh: add hp sw " Chandra Seetharaman
2008-01-24 0:32 ` [PATCH 7/9] scsi_dh: Add support for SDEV_PASSIVE Chandra Seetharaman
2008-02-04 18:58 ` James Bottomley
2008-02-04 20:15 ` Chandra Seetharaman
2008-02-04 20:28 ` James Bottomley
2008-02-04 21:19 ` Chandra Seetharaman
2008-02-09 12:45 ` Matthew Wilcox
2008-02-11 18:27 ` Chandra Seetharaman
2008-02-11 19:18 ` Matthew Wilcox
2008-02-28 1:03 ` Chandra Seetharaman
2008-02-05 20:04 ` Mike Christie
2008-02-05 21:56 ` Mike Anderson
2008-02-06 0:46 ` Chandra Seetharaman
2008-02-07 10:08 ` no INQUIRY from userspace please (was Re: [PATCH 7/9] scsi_dh: Add support for SDEV_PASSIVE) Stefan Richter
2008-02-07 15:01 ` James Bottomley
2008-02-07 17:05 ` no INQUIRY from userspace please Stefan Richter
2008-02-07 17:13 ` Stefan Richter
2008-02-19 20:53 ` Douglas Gilbert
2008-03-04 9:06 ` Hannes Reinecke
2008-02-07 20:42 ` no INQUIRY from userspace please (was Re: [PATCH 7/9] scsi_dh: Add support for SDEV_PASSIVE) Luben Tuikov
2008-02-04 20:26 ` [PATCH 7/9] scsi_dh: Add support for SDEV_PASSIVE Mike Anderson
2008-01-24 0:32 ` [PATCH 8/9] scsi_dh: add lsi rdac device handler Chandra Seetharaman
2008-01-24 0:32 ` [PATCH 9/9] scsi_dh: add scsi device handler to dm Chandra Seetharaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080124003042.18871.69006.sendpatchset@localhost.localdomain \
--to=sekharan@us.ibm.com \
--cc=andmike@us.ibm.com \
--cc=dm-devel@redhat.com \
--cc=jens.axboe@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.