From: Samuel Thibault <samuel.thibault@eu.citrix.com>
To: "Mike D. Day" <ncmike@us.ibm.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: ioemu: use asprintf instead of PATH_MAX
Date: Thu, 24 Jan 2008 01:38:50 +0000 [thread overview]
Message-ID: <20080124013850.GJ4320@implementation> (raw)
In-Reply-To: <20080123205347.GA12631@silverwood.ncultra.org>
Mike D. Day, le Wed 23 Jan 2008 15:53:47 -0500, a écrit :
> erOn 23/01/08 17:20 +0000, Samuel Thibault wrote:
> > Use asprintf instead of PATH_MAX, which POSIX says to be facultative.
> >
> > Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>
>
> > - snprintf(qemu_file, sizeof(qemu_file),
> > - "/var/lib/xen/qemu-save.%d", domid);
> > + asprintf(&qemu_file, "/var/lib/xen/qemu-save.%d", domid);
>
> Just a question - afaik asprintf is a unix-ism that isn't supported on
> windows. Will this cause problems if also pushed to upstream qemu?
qemu is quite often used in windows too so that would pose problem
indeed. But I guess the /var/lib patch would too anyway :) And this
part of the code is actually xen-specific.
Samuel
next prev parent reply other threads:[~2008-01-24 1:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 17:20 [PATCH] ioemu: use asprintf instead of PATH_MAX Samuel Thibault
2008-01-23 20:53 ` Mike D. Day
2008-01-24 1:38 ` Samuel Thibault [this message]
2008-01-24 14:45 ` Mike D. Day
2008-01-24 14:56 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080124013850.GJ4320@implementation \
--to=samuel.thibault@eu.citrix.com \
--cc=ncmike@us.ibm.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.