All of lore.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Zhang Rui <rui.zhang@intel.com>,
	linux-acpi@vger.kernel.org, linux-pm@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, sujith.thomas@intel.com
Subject: Re: [PATCH 9/10] introduce intel_menlow platform specific driver
Date: Thu, 24 Jan 2008 16:39:33 -0500	[thread overview]
Message-ID: <200801241639.33898.lenb@kernel.org> (raw)
In-Reply-To: <20080121095331.GA5333@infradead.org>

On Monday 21 January 2008 04:53, Christoph Hellwig wrote:
> On Thu, Jan 17, 2008 at 03:51:17PM +0800, Zhang Rui wrote:
> > From: Thomas Sujith <sujith.thomas@intel.com>
> > 
> > Intel menlow platform specific driver for thermal management.
> > 
> > Signed-off-by: Thomas Sujith <sujith.thomas@intel.com>
> > Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> > ---
> >  drivers/misc/Kconfig        |   10 
> >  drivers/misc/Makefile       |    1 
> >  drivers/misc/intel_menlow.c |  527 ++++++++++++++++++++++++++++++++++++++++++++
> 
> Why is this in drivers/misc?  I don't have a thermal.h in mainline, but
> if this is a new subsystem your adding care to create a directory under
> drivers/ for it?

Hi Christoph,

I'm sure it was me who suggested putting intel_menlo.c under drivers/misc.

A while back I refused to let any new platform specific drivers under
drivers/acpi, and asked that the ones here already move out.
This is because they happne to use ACPI, but are not actually
part of the ACPI sub-system (any more than ATA is).
Also, I wanted the maintainer roles to be clear -- these
drivers have primary maintainers other than me, and those
guys are in the heroic, but tragic, business of writing
platform-specific drivers for systems with no documentation or vendor support.

drivers/misc/asus-laptop.c
drivers/misc/fujitsu-laptop.c
drivers/misc/msi-laptop.c
drivers/misc/sony-laptop.c
drivers/misc/thinkpad_acpi.c
drivers/misc/sony-laptop.c

intel_menlo.c fits in with this group, the only difference is that
its primary maintainers actually have documentation:-)

is there a better place than drivers/misc for this group?

thanks,
-Len


  parent reply	other threads:[~2008-01-24 21:39 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-17  7:51 [PATCH 9/10] introduce intel_menlow platform specific driver Zhang Rui
2008-01-17  8:18 ` Sam Ravnborg
2008-01-17  8:18 ` Sam Ravnborg
2008-01-17 17:20 ` Randy Dunlap
2008-01-17 19:51   ` Len Brown
2008-01-17 19:51   ` Len Brown
2008-01-17 20:51     ` Randy Dunlap
2008-01-17 20:51     ` Randy Dunlap
2008-01-18  3:32   ` Zhang Rui
2008-01-18  3:55     ` Li Zefan
2008-01-18  3:55     ` Li Zefan
2008-01-18  3:55       ` Li Zefan
2008-01-21  5:26       ` Thomas, Sujith
2008-01-21  5:26       ` Thomas, Sujith
2008-01-21  5:26         ` Thomas, Sujith
2008-01-21  5:45         ` Li Zefan
2008-01-25  3:45           ` Zhang Rui
2008-01-25  3:45           ` Zhang Rui
2008-01-21  5:45         ` Li Zefan
2008-01-18  3:32   ` Zhang Rui
2008-01-17 17:20 ` Randy Dunlap
2008-01-21  9:53 ` Christoph Hellwig
2008-01-21  9:53 ` Christoph Hellwig
2008-01-21 14:19   ` Thomas, Sujith
2008-01-21 14:19     ` Thomas, Sujith
2008-01-23 15:58     ` Jan Engelhardt
2008-01-23 15:58     ` Jan Engelhardt
2008-01-21 14:19   ` Thomas, Sujith
2008-01-24 21:39   ` Len Brown
2008-01-24 21:39   ` Len Brown [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-01-17  7:51 Zhang Rui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801241639.33898.lenb@kernel.org \
    --to=lenb@kernel.org \
    --cc=hch@infradead.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=rui.zhang@intel.com \
    --cc=sujith.thomas@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.