From: "Yoshinori K. Okuji" <okuji@enbug.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: /kern/file.c BUG
Date: Thu, 24 Jan 2008 22:19:55 +0100 [thread overview]
Message-ID: <200801242219.55828.okuji@enbug.org> (raw)
In-Reply-To: <1201199662.19286.4.camel@dv>
On Thursday 24 January 2008 19:34, Pavel Roskin wrote:
> On Thu, 2008-01-24 at 20:08 +0200, Vesa Jääskeläinen wrote:
> > Previous behavior was working correctly. You have to handle
> > errorcodes
> > at some point and that means when error is handled it is zeroed (or
> > GRUB_ERR_NONE). So code is in callee where that loop was.
>
> I suggest that we never set grub_errno to 0 (except the initialization).
> That would match the standard errno behavior:
>
> http://www.opengroup.org/onlinepubs/009695399/functions/errno.html
Marco is right. As you pointed out, our error handling is different from errno
on Unix, but this is intentional, because I stole the model from GRUB Legacy
and Parted.
Okuji
next prev parent reply other threads:[~2008-01-24 21:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 23:00 /kern/file.c BUG Oleg Strikov
2008-01-24 0:05 ` Robert Millan
2008-01-24 18:08 ` Vesa Jääskeläinen
2008-01-24 18:34 ` Pavel Roskin
2008-01-24 21:19 ` Yoshinori K. Okuji [this message]
2008-01-24 22:09 ` Marco Gerards
2008-01-24 23:00 ` Robert Millan
2008-01-24 23:27 ` Robert Millan
2008-01-25 8:47 ` Marco Gerards
2008-01-25 8:45 ` Marco Gerards
2008-01-25 8:50 ` Marco Gerards
2008-01-25 23:57 ` Robert Millan
2008-01-26 12:04 ` Marco Gerards
2008-01-26 17:05 ` Robert Millan
-- strict thread matches above, loose matches on Subject: below --
2008-01-24 21:43 Oleg Strikov
2008-01-25 3:22 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801242219.55828.okuji@enbug.org \
--to=okuji@enbug.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.