From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JIBYD-0008Ks-Eb for mharc-grub-devel@gnu.org; Thu, 24 Jan 2008 18:32:05 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JIBYC-0008Jq-Ky for grub-devel@gnu.org; Thu, 24 Jan 2008 18:32:04 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JIBYA-0008Gi-Qd for grub-devel@gnu.org; Thu, 24 Jan 2008 18:32:04 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JIBYA-0008GY-NK for grub-devel@gnu.org; Thu, 24 Jan 2008 18:32:02 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JIBYA-0005B0-DZ for grub-devel@gnu.org; Thu, 24 Jan 2008 18:32:02 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JIBWC-00007t-7E for grub-devel@gnu.org; Fri, 25 Jan 2008 00:30:00 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JIBTu-000887-98 for grub-devel@gnu.org; Fri, 25 Jan 2008 00:27:38 +0100 Date: Fri, 25 Jan 2008 00:27:38 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080124232738.GA31192@thorin> References: <94a0ccbc0801231500g752f72acodc37c733726d8919@mail.gmail.com> <4798D42E.7030506@nic.fi> <1201199662.19286.4.camel@dv> <200801242219.55828.okuji@enbug.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <200801242219.55828.okuji@enbug.org> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: /kern/file.c BUG X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jan 2008 23:32:04 -0000 On Thu, Jan 24, 2008 at 10:19:55PM +0100, Yoshinori K. Okuji wrote: > On Thursday 24 January 2008 19:34, Pavel Roskin wrote: > > On Thu, 2008-01-24 at 20:08 +0200, Vesa Jääskeläinen wrote: > > > Previous behavior was working correctly. You have to handle > > > errorcodes > > > at some point and that means when error is handled it is zeroed (or > > > GRUB_ERR_NONE). So code is in callee where that loop was. > > > > I suggest that we never set grub_errno to 0 (except the initialization). > > That would match the standard errno behavior: > > > > http://www.opengroup.org/onlinepubs/009695399/functions/errno.html > > Marco is right. As you pointed out, our error handling is different from errno > on Unix, but this is intentional, because I stole the model from GRUB Legacy > and Parted. Could you explain how is it supposed to work? There were clearly two bugs, which I "fixed" in grub_disk_open first, and in grub_file_open. The solution can be wrong, but the bugs still existed. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)