From: Philipp Matthias Hahn <pmhahn@titan.lahn.de>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-input@vger.kernel.org
Subject: [PATCH] linux-2.6.24/drivers/hid/hid-input.c
Date: Fri, 25 Jan 2008 11:11:34 +0100 [thread overview]
Message-ID: <20080125101134.GA3802@titan.lahn.de> (raw)
In-Reply-To: <alpine.LFD.1.00.0801241506500.15329@hp.linux-foundation.org>
In hidinput_configure_usage(device), IS_CHICONY_TACTICAL_PAD(devic) gets
passed the 'device' parameter. But that macro still references its
parameter by 'device' instead of by its local name 'x'.
Signed-off-by: Philipp Matthias Hahn <pmhahn@titan.lahn.de>
--- linux/drivers/hid/hid-input.c 2008-01-25 09:57:17.000000000 +0100
+++ linux/drivers/hid/hid-input.c 2008-01-25 10:56:35.835871529 +0100
@@ -87,7 +87,7 @@
#define map_key_clear(c) do { map_key(c); clear_bit(c, bit); } while (0)
/* hardware needing special handling due to colliding MSVENDOR page usages */
-#define IS_CHICONY_TACTICAL_PAD(x) (x->vendor == 0x04f2 && device->product == 0x0418)
+#define IS_CHICONY_TACTICAL_PAD(x) (x->vendor == 0x04f2 && x->product == 0x0418)
#define IS_MS_KB(x) (x->vendor == 0x045e && (x->product == 0x00db || x->product == 0x00f9))
#ifdef CONFIG_USB_HIDINPUT_POWERBOOK
--
/ / (_)__ __ ____ __ Philipp Hahn
/ /__/ / _ \/ // /\ \/ /
/____/_/_//_/\_,_/ /_/\_\ pmhahn@titan.lahn.de
next prev parent reply other threads:[~2008-01-25 10:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-24 23:17 Linux 2.6.24 Linus Torvalds
2008-01-24 23:41 ` Linus Torvalds
2008-01-25 9:10 ` Giacomo A. Catenazzi
2008-01-25 9:58 ` Valdis.Kletnieks
2008-01-25 11:58 ` Rafael J. Wysocki
2008-01-25 12:34 ` Giacomo A. Catenazzi
2008-01-25 23:50 ` Stefan Richter
2008-01-26 0:42 ` using LKML for subsystem development (was Re: Linux 2.6.24) Stefan Richter
2008-01-26 3:28 ` Valdis.Kletnieks
2008-01-26 13:31 ` using LKML for subsystem development Stefan Richter
2008-01-27 7:37 ` Valdis.Kletnieks
2008-01-26 11:28 ` using LKML for subsystem development (was Re: Linux 2.6.24) Ingo Molnar
2008-01-26 14:07 ` using LKML for subsystem development David Miller
2008-01-26 14:45 ` Stefan Richter
2008-01-26 14:25 ` Stefan Richter
2008-02-01 9:40 ` Ingo Molnar
2008-02-01 19:53 ` Stefan Richter
2008-01-26 3:19 ` Linux 2.6.24 Valdis.Kletnieks
2008-01-25 11:35 ` Ingo Molnar
2008-01-25 10:11 ` Philipp Matthias Hahn [this message]
2008-01-25 10:30 ` [PATCH] linux-2.6.24/drivers/hid/hid-input.c Jiri Kosina
2008-02-03 12:35 ` Linux 2.6.24 Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080125101134.GA3802@titan.lahn.de \
--to=pmhahn@titan.lahn.de \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.