From: Chris Mason <chris.mason@oracle.com>
To: Jan Kara <jack@suse.cz>
Cc: Zach Brown <zach.brown@oracle.com>,
Erez Zadok <ezk@cs.sunysb.edu>,
linux-kernel@vger.kernel.org, ext3-users@redhat.com,
Peter Zijlstra <peterz@infradead.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: lockdep warning with LTP dio test (v2.6.24-rc6-125-g5356f66)
Date: Fri, 25 Jan 2008 11:16:13 -0500 [thread overview]
Message-ID: <200801251116.13690.chris.mason@oracle.com> (raw)
In-Reply-To: <20080125160931.GC1767@duck.suse.cz>
On Friday 25 January 2008, Jan Kara wrote:
> > If ext3's DIO code only touches transactions in get_block, then it can
> > violate data=ordered rules. Basically the transaction that allocates
> > the blocks might commit before the DIO code gets around to writing them.
> >
> > A crash in the wrong place will expose stale data on disk.
>
> Hmm, I've looked at it and I don't think so - look at the rationale in
> the patch below... That patch should fix the lock-inversion problem (at
> least I see no lockdep warnings on my test machine).
>
Ah ok, when I was looking at this I was allowing holes to get filled without
falling back to buffered. But, with the orphan inode entry protecting things
I see how you're safe with this patch.
-chris
prev parent reply other threads:[~2008-01-25 16:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-24 23:02 lockdep warning with LTP dio test (v2.6.24-rc6-125-g5356f66) Erez Zadok
2008-01-02 20:42 ` Zach Brown
2008-01-14 17:06 ` Jan Kara
2008-01-14 18:14 ` Chris Mason
2008-01-25 16:09 ` Jan Kara
2008-01-25 16:16 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801251116.13690.chris.mason@oracle.com \
--to=chris.mason@oracle.com \
--cc=ext3-users@redhat.com \
--cc=ezk@cs.sunysb.edu \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.