Re: [PATCH] KVM: VMX: Enable Virtual Processor Identification (VPID)

["Yang, Sheng" <sheng.yang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

On Friday 25 January 2008 14:52:47 Avi Kivity wrote:
> Yang, Sheng wrote:
> > Here is the updated patch:
>
> Applied, thanks.
>
> > @@ -1714,6 +1788,8 @@ static int vmx_vcpu_reset(struct kvm_vcpu *vcpu)
> >  	vmx_fpu_activate(&vmx->vcpu);
> >  	update_exception_bitmap(&vmx->vcpu);
> >
> > +	vpid_sync_all();
> > +
> >  	return 0;
>
> This causes the new instruction to be executed unconditionally, which
> would #UD on older processors, no?  I replaced it with
> vpid_sync_vcpu_all() which seems sufficient, or do I miss something?

I think it's OK for there is a judgment in __invvpid() to see if machine has 
the ability(also if it is allowed to using VPID). :)

Thanks!

-- 
Thanks
Yang, Sheng

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/