From: Frans Pop <elendil@planet.nl>
To: Jochen Friedrich <jochen@scram.de>
Cc: galak@kernel.crashing.org, geert@linux-m68k.org,
gerg@uclinux.org, jgarzik@pobox.com,
linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org,
linuxppc-dev@ozlabs.org, netdev@vger.kernel.org,
scottwood@freescale.com, vitb@kernel.crashing.org
Subject: Re: [PATCH] [NET]: Remove PowerPC code from fec.c
Date: Fri, 25 Jan 2008 17:31:54 +0100 [thread overview]
Message-ID: <200801251731.56378.elendil@planet.nl> (raw)
In-Reply-To: <479A087F.5010305@scram.de>
On Friday 25 January 2008, Jochen Friedrich wrote:
> > Jochen Friedrich wrote:
> >> +++ b/drivers/net/fec.c
> >> @@ -23,6 +23,9 @@
> >> *
> >> * Bug fixes and cleanup by Philippe De Muyter (phdm@macqel.be)
> >> * Copyright (c) 2004-2006 Macq Electronique SA.
> >> + *
> >> + * This driver is now only used on ColdFire processors. Remove conditional
> >> + * Powerpc code.
> >> */
> >
> > This comment makes sense for a changelog, but IMO it makes no sense at
> > all to add it to the file.
>
> I just added it to clarify this code is now only used on m68knommu
> (Coldfire). The comments on top are mailny about MPC860T CPUs (PowerPC),
> however the driver is no longer used for these CPUs.
>
> Maybe the wording should be changed to:
>
> This driver is now only used on ColdFire (m68knommu) processors.
> Conditional PowerPC code has been removed.
Yes, that certainly makes more sense, although IMHO the second sentence is
still somewhat redundant. (My problem was mainly with the second sentence.
I should have made that more clear, sorry.)
next prev parent reply other threads:[~2008-01-25 16:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-25 14:33 [PATCH] [NET]: Remove PowerPC code from fec.c Jochen Friedrich
2008-01-25 14:33 ` Jochen Friedrich
2008-01-25 14:46 ` Geert Uytterhoeven
2008-01-25 14:46 ` Geert Uytterhoeven
2008-01-28 23:58 ` Greg Ungerer
2008-01-28 23:58 ` Greg Ungerer
2008-01-25 15:50 ` Frans Pop
2008-01-25 16:04 ` Jochen Friedrich
2008-01-25 16:04 ` Jochen Friedrich
2008-01-25 16:31 ` Frans Pop [this message]
2008-01-28 21:01 ` Arnd Bergmann
2008-01-28 21:01 ` Arnd Bergmann
2008-01-30 8:41 ` Jeff Garzik
2008-01-30 8:41 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801251731.56378.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=galak@kernel.crashing.org \
--cc=geert@linux-m68k.org \
--cc=gerg@uclinux.org \
--cc=jgarzik@pobox.com \
--cc=jochen@scram.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=scottwood@freescale.com \
--cc=vitb@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.