From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JIYRS-0005BM-Gc for mharc-grub-devel@gnu.org; Fri, 25 Jan 2008 18:58:38 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JIYRQ-0005BH-9R for grub-devel@gnu.org; Fri, 25 Jan 2008 18:58:36 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JIYRN-0005B5-Ul for grub-devel@gnu.org; Fri, 25 Jan 2008 18:58:35 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JIYRN-0005B2-Ox for grub-devel@gnu.org; Fri, 25 Jan 2008 18:58:33 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JIYRN-00009p-Jy for grub-devel@gnu.org; Fri, 25 Jan 2008 18:58:33 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JIYRK-00035x-36 for grub-devel@gnu.org; Sat, 26 Jan 2008 00:58:30 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JIYPs-0006Ul-P4 for grub-devel@gnu.org; Sat, 26 Jan 2008 00:57:00 +0100 Date: Sat, 26 Jan 2008 00:57:00 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080125235700.GA24946@thorin> References: <94a0ccbc0801231500g752f72acodc37c733726d8919@mail.gmail.com> <20080124000544.GB32503@thorin> <4798D42E.7030506@nic.fi> <87odbal261.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87odbal261.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: /kern/file.c BUG X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2008 23:58:36 -0000 On Fri, Jan 25, 2008 at 09:50:14AM +0100, Marco Gerards wrote: > Vesa Jääskeläinen writes: > > (replying to this mail, I didn't receive the first mail over the list...) > > > Robert Millan wrote: > >> On Wed, Jan 23, 2008 at 11:00:57PM +0000, Oleg Strikov wrote: > >>> Incorrect behavior of grub_file_open () function in e.g. loop context: > >>> > >>> char *file_names[] = > >>> { > >>> "(hd0,1)/file1", //file do not exist > >>> "(hd0,1)/file2" //file exist > >>> }; > >>> grub_file_t file; > >>> int i; > >>> for (i = 0; i < 2; i++) > >>> { > >>> file = grub_file_open (file_names[i]); > >>> if (file) {...} > >>> } > >>> > >>> There, we should get positive return in the second case (i == 1), but > >>> grub_file_open() returns 0. > > No, that is not right. This behavior is correct. > > When you open the first file, you get an error which you ignore. If > you think this error is harmless, clear it. So your code is wrong. Ok, I reverted it. This will uncover another bug somewhere else. I can't remember what it was about, though. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)