From: Jarek Poplawski <jarkao2@gmail.com>
To: Joonwoo Park <joonwpark81@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org, bugme-daemon@bugzilla.kernel.org,
schwab@suse.de
Subject: Re: [Bugme-new] [Bug 9816] New: cannot replace route
Date: Sat, 26 Jan 2008 15:10:10 +0100 [thread overview]
Message-ID: <20080126141010.GC2624@ami.dom.local> (raw)
In-Reply-To: <20080126114036.GA2624@ami.dom.local>
On Sat, Jan 26, 2008 at 12:40:36PM +0100, Jarek Poplawski wrote:
> On Sat, Jan 26, 2008 at 02:16:01PM +0900, Joonwoo Park wrote:
> > 2008/1/26, Andrew Morton <akpm@linux-foundation.org>:
> > >
> > > But whatever. It used to work. People's scripts will break. Regression.
> > >
> >
> > Also I thought that 'replace with itself' should be error as like Jarek.
> > But it used to work and patch made a regression, it's my bad :(
>
> Actually, I don't think 'replace with itself' should be an error. I've
> only meant that lack of this possibility shouldn't be necessarily seen
> as error - there could be arguments for both sides.
...On the other hand, after some re-thinking, I actually think 'replace
with itself' should be considered a bug. I wondered about the possible
reason of this behaviour in a file system, and it seems replace just
means things like overwrite, so old thing is always supposed to be
destroyed (of course it's a matter of implementation or conditions in
which moment this destruction takes place).
So, 'replace with itself' is simply ambiguous: we can always delete the
object first, to prepare the place for replacement, and find there is
nothing to do after this - and it's probably not what somebody wanted.
And, after re-reading this bugzilla report, I'm pretty sure the thing
should be done with 'ip route change' (but I didn't check if 2.6.24
knows about this...).
Jarek P.
next prev parent reply other threads:[~2008-01-26 14:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-9816-10286@http.bugzilla.kernel.org/>
2008-01-25 22:26 ` [Bugme-new] [Bug 9816] New: cannot replace route Andrew Morton
2008-01-25 23:11 ` Jarek Poplawski
2008-01-26 3:20 ` Andrew Morton
2008-01-26 5:16 ` Joonwoo Park
2008-01-26 11:40 ` Jarek Poplawski
2008-01-26 14:10 ` Jarek Poplawski [this message]
2008-01-26 14:27 ` Andreas Schwab
2008-01-26 15:19 ` Jarek Poplawski
2008-01-27 1:11 ` Jarek Poplawski
2008-01-27 7:58 ` Jarek Poplawski
2008-01-27 9:49 ` Julian Anastasov
2008-01-27 11:14 ` Jarek Poplawski
2008-01-26 14:32 ` Jarek Poplawski
2008-01-26 12:10 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080126141010.GC2624@ami.dom.local \
--to=jarkao2@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=joonwpark81@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.