From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JIrbt-00052Y-3V for mharc-grub-devel@gnu.org; Sat, 26 Jan 2008 15:26:41 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JIrbr-00051G-C5 for grub-devel@gnu.org; Sat, 26 Jan 2008 15:26:39 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JIrbp-0004zX-G5 for grub-devel@gnu.org; Sat, 26 Jan 2008 15:26:38 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JIrbp-0004zU-AN for grub-devel@gnu.org; Sat, 26 Jan 2008 15:26:37 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JIrbl-0003Xu-L2; Sat, 26 Jan 2008 15:26:33 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JIrbk-0005BC-2P; Sat, 26 Jan 2008 21:26:32 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JIraE-0001vS-05; Sat, 26 Jan 2008 21:24:58 +0100 Date: Sat, 26 Jan 2008 21:24:57 +0100 From: Robert Millan To: Pavel Roskin Message-ID: <20080126202457.GA7323@thorin> References: <20080126194444.16214.26226.stgit@dv.roinet.com> <20080126195937.GC6486@thorin> <20080126151102.lo2xgh1bi88ksw4k@webmail.spamcop.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20080126151102.lo2xgh1bi88ksw4k@webmail.spamcop.net> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Cc: The development of GRUB 2 Subject: Re: [PATCH] Don't abort if prefix is not set X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jan 2008 20:26:39 -0000 On Sat, Jan 26, 2008 at 03:11:02PM -0500, Pavel Roskin wrote: > Quoting Robert Millan : > > >>+ if (! grub_dl_dir) { > >>+ grub_error (GRUB_ERR_FILE_NOT_FOUND, "\"prefix\" is not set"); > >>+ return 0; > > > >Seems fine, but are you sure this error is handled somewhere? > > If prefix is not set, the module is not loaded. What other handling > do we need? What I mean is, is the error message printed? I recall it had to be handled somewhere. Or maybe I'm confused... > I found that prefix would not be set on PowerPC if /memory/available > is missing. Sounds strange.. how is that so? > Even though I have a better workaround for it now, I > still think that aborting for such minor reason is wrong. After all, > the user may unset prefix. Agreed.. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)