From: Andrew Morton <akpm@linux-foundation.org>
To: David Teigland <teigland@redhat.com>
Cc: linux-kernel@vger.kernel.org, fabbione@ubuntu.com
Subject: Re: [PATCH 07/19] dlm: swap bytes for rcom lock reply
Date: Sat, 26 Jan 2008 22:00:29 -0800 [thread overview]
Message-ID: <20080126220029.98dc3826.akpm@linux-foundation.org> (raw)
In-Reply-To: <1201193442-8260-8-git-send-email-teigland@redhat.com>
> On Thu, 24 Jan 2008 10:50:30 -0600 David Teigland <teigland@redhat.com> wrote:
> void dlm_rcom_in(struct dlm_rcom *rc)
> {
> struct dlm_header *hd = (struct dlm_header *) rc;
aww, c'mon guys, this is nonsense.
struct dlm_header *hd = &rc->rc_header;
there seems to be rather a lot of this unnecessary casting going on in dlm.
Please do a hunt-and-exterminate.
next prev parent reply other threads:[~2008-01-27 6:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-24 16:50 [PATCH 07/19] dlm: swap bytes for rcom lock reply David Teigland
2008-01-27 6:00 ` Andrew Morton [this message]
2008-01-28 16:20 ` David Teigland
2008-01-29 22:00 ` David Teigland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080126220029.98dc3826.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=fabbione@ubuntu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.