From: Andrew Morton <akpm@linux-foundation.org>
To: Alex Dubov <oakad@yahoo.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [MEMSTICK] Updates for the memstick driver
Date: Sat, 26 Jan 2008 22:01:47 -0800 [thread overview]
Message-ID: <20080126220147.c9be389e.akpm@linux-foundation.org> (raw)
In-Reply-To: <439089.5370.qm@web36701.mail.mud.yahoo.com>
> On Thu, 24 Jan 2008 23:58:52 -0800 (PST) Alex Dubov <oakad@yahoo.com> wrote:
> * Mark shared inline functions as static
>
> * Use member-at-a-time assignment for protocol structures
>
> * Comments for publicly exported functions
>
> * Use end_queued_request to end unhandled block layer requests
>
> * Use sysfs attribute group to export MSPro attributes
>
> * Fix includes
>
> * Use scnprintf instead of snprintf where string length matters
>
> * Remove spurious get_device/put_device in probe method
>
Please sign off your patches.
Please don't send wordwrapped patches.
Please put the subsystem identifier "memstick" outside [], for reasons
described in http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt
Your patch contained a fix which I already merged into -mm, which suggests
that you haven't been testing the code in 2.6.24-rc8-mm1. Please do test
-mm when you have patches in there, so that we know that we'll be merging
things which work.
Thanks.
next prev parent reply other threads:[~2008-01-27 6:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-02 6:42 [PATCH] [MEMSTICK] Initial commit for Sony MemoryStick support oakad
2008-01-10 9:00 ` Andrew Morton
2008-01-11 12:14 ` Jens Axboe
2008-01-14 3:26 ` Alex Dubov
2008-01-22 16:12 ` Alex Dubov
2008-01-22 18:59 ` Andrew Morton
2008-01-25 7:58 ` [PATCH] [MEMSTICK] Updates for the memstick driver Alex Dubov
2008-01-27 6:01 ` Andrew Morton [this message]
2008-02-03 0:16 ` Andrew Morton
2008-02-04 4:31 ` [PATCH] memstick: use __blk_end_request to complete requests Alex Dubov
2008-02-04 7:07 ` Andrew Morton
2008-02-09 14:59 ` [PATCH] memstick: fix attribute structure casting in mspro_block_resume Alex Dubov
2008-01-15 17:21 ` [PATCH] [MEMSTICK] Initial commit for Sony MemoryStick support Mariusz Kozlowski
2008-01-16 1:52 ` Alex Dubov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080126220147.c9be389e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oakad@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.