From: Olaf Hering <olaf@aepfle.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] unifdef linux/vt.h
Date: Sun, 27 Jan 2008 12:52:32 +0100 [thread overview]
Message-ID: <20080127115232.GA5373@aepfle.de> (raw)
In-Reply-To: <20080126202010.GA28444@infradead.org>
On Sat, Jan 26, Christoph Hellwig wrote:
> On Fri, Jan 25, 2008 at 07:02:15PM +0100, Olaf Hering wrote:
> >
> > remove the newly added __KERNEL__ block from linux/vt.h
> >
> > Signed-off-by: Olaf Hering <olaf@aepfle.de>
>
> We shouldn't add more unifdef-y headers. Please move the newly-added
> kernel-only section to a different file instead and beat up the person
> who introduced it with a big cluestick.
Suggest a place, please.
Also, I think every header should go throug unifdef.
next prev parent reply other threads:[~2008-01-27 11:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-25 18:02 [PATCH] unifdef linux/vt.h Olaf Hering
2008-01-25 18:03 ` [PATCH] hide kernel only code in linux/jbd.h Olaf Hering
2008-01-26 20:20 ` [PATCH] unifdef linux/vt.h Christoph Hellwig
2008-01-27 11:52 ` Olaf Hering [this message]
2008-02-08 17:38 ` Olaf Hering
2008-02-08 21:29 ` Andrew Morton
2008-02-10 9:54 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080127115232.GA5373@aepfle.de \
--to=olaf@aepfle.de \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.