From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JJDPk-0003nO-Ku for mharc-grub-devel@gnu.org; Sun, 27 Jan 2008 14:43:36 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JJDPj-0003mi-Dj for grub-devel@gnu.org; Sun, 27 Jan 2008 14:43:35 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JJDPh-0003l7-Tp for grub-devel@gnu.org; Sun, 27 Jan 2008 14:43:35 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JJDPh-0003l0-Oi for grub-devel@gnu.org; Sun, 27 Jan 2008 14:43:33 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JJDPh-0003Wb-Dp for grub-devel@gnu.org; Sun, 27 Jan 2008 14:43:33 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JJDPe-0005ys-3o for grub-devel@gnu.org; Sun, 27 Jan 2008 20:43:32 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JJDNn-0001y9-Bm for grub-devel@gnu.org; Sun, 27 Jan 2008 20:41:35 +0100 Date: Sun, 27 Jan 2008 20:41:35 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080127194135.GA7041@thorin> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] a.out kernel loader X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jan 2008 19:43:35 -0000 On Mon, Jan 28, 2008 at 02:53:14AM +0800, Bean wrote: > Hi, > > This patch add support for a.out kernel, which includes the 4th loader > of BSD system. For example, to start FreeBSD: Cool! How FreeBSD-specific is this? Will the same module apply to other a.out binaries ? (I ask since you gave it a generic name) > +++ b/loader/i386/pc/aout.c How i386-specific is it? Can it possibly work for non-i386 objects in the future? > +/* a_mid */ > +#define MID_ZERO 0 /* unknown - implementation dependent */ > +#define MID_SUN010 1 /* sun 68010/68020 binary */ > +#define MID_SUN020 2 /* sun 68020-only binary */ > +#define MID_I386 134 /* i386 BSD binary */ > +#define MID_SPARC 138 /* sparc */ > +#define MID_HP200 200 /* hp200 (68010) BSD binary */ > +#define MID_HP300 300 /* hp300 (68020+68881) BSD binary */ > +#define MID_HPUX 0x20C /* hp200/300 HP-UX binary */ > +#define MID_HPUX800 0x20B /* hp800 HP-UX binary */ These aren't used through the code. Did you copy them from a standard header or so? > +static grub_err_t > +grub_aout_boot (void) > +{ > + grub_multiboot_real_boot (entry, 0); Ugh :-) Is there really anything desired from grub_multiboot_real_boot? (other than grub_dl_unload_all and grub_stop_floppy) I wonder if it makes sense to split grub_dl_unload_all/grub_stop_floppy out of grub_multiboot_real_boot to make a generic "real_boot" function that lives in kernel and is used by grub_multiboot_real_boot and directly by modules like this one. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)