All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
Cc: Dmitri Vorobiev <dmitri.vorobiev@gmail.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c
Date: Sun, 27 Jan 2008 23:01:04 +0100	[thread overview]
Message-ID: <20080127220104.GA3503@elte.hu> (raw)
In-Reply-To: <4d8e3fd30801271351p44818f64p27ca4ae897efbb81@mail.gmail.com>


* Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> wrote:

> On Jan 27, 2008 10:45 PM, Dmitri Vorobiev <dmitri.vorobiev@gmail.com> wrote:
> > > -  math_abort(FPU_info,SIGILL);
> > > +  math_abort(FPU_info , SIGILL);
> >
> > Looks like you're trading bad for worse here.
> 
> Should I make it read like math_abort(FPU_info, SIGILL); ?

yeah, that's the correct one.

> > While you're at it, please think about adding proper KERN_ facility to these printk() calls.
> 
> Yes, basically all the warnings are about missing KERN_. Do you want 
> me to add KERN_ERR to all the above printk?

Do that in a separate patch though, as it changes strings. (and hence 
the checking for 'did the object md5 change' misfires)

	Ingo

      reply	other threads:[~2008-01-27 22:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-27 21:34 [PATCH] X86: coding style fixes to arch/x86/math-errors.c Paolo Ciarrocchi
2008-01-27 21:45 ` Dmitri Vorobiev
2008-01-27 21:51   ` Paolo Ciarrocchi
2008-01-27 22:01     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080127220104.GA3503@elte.hu \
    --to=mingo@elte.hu \
    --cc=dmitri.vorobiev@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paolo.ciarrocchi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.