From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JJQ18-00005X-NJ for mharc-grub-devel@gnu.org; Mon, 28 Jan 2008 04:11:02 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JJQ16-00004w-Ow for grub-devel@gnu.org; Mon, 28 Jan 2008 04:11:00 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JJQ15-0008W6-Se for grub-devel@gnu.org; Mon, 28 Jan 2008 04:11:00 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JJQ15-0008Vz-LZ for grub-devel@gnu.org; Mon, 28 Jan 2008 04:10:59 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JJQ15-0003I0-FU for grub-devel@gnu.org; Mon, 28 Jan 2008 04:10:59 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JJQ12-0007La-TQ for grub-devel@gnu.org; Mon, 28 Jan 2008 10:10:58 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JJPzK-0003eP-NQ for grub-devel@gnu.org; Mon, 28 Jan 2008 10:09:10 +0100 Date: Mon, 28 Jan 2008 10:09:10 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080128090910.GC13368@thorin> References: <1201490732.20392.15.camel@rd> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1201490732.20392.15.camel@rd> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Redefining GRUB_MOD_GAP in init.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2008 09:11:01 -0000 On Sun, Jan 27, 2008 at 10:25:32PM -0500, Pavel Roskin wrote: > Hi Robert, > > I'm concerned about your latest commit: > > * kern/powerpc/ieee1275/init.c (grub_arch_modules_addr): Skip > `GRUB_MOD_GAP' for platforms in which it's not defined. > > The algorithm for calculating the start of the modules should be exactly > the same in grub-mkimage and in the core. Any fallbacks should be > coherent if possible. Therefore, I think it would be better to define > GRUB_MOD_GAP only in header files. Sorry, I should've really sent this for review; it wasn't such an obvious fix as you pointed out. I'll get that moved to headers as you suggest. > Also, I don't see how GRUB_MOD_GAP would not be defined to 0x8000 for > i386-ieee1275 platform considering that > include/grub/i386/ieee1275/kernel.h simply includes > include/grub/powerpc/ieee1275/kernel.h Sounds strange.. I'm wondering that myself. Will check.. > It's hard for me to understand why kern/powerpc/ieee1275/init.c can be > used on any platform other than PowerPC. I was assuming that my changes > would not affect other platforms. > > [...] > I suggest that i386-ieee1275 stops using any files for PowerPC. > kernel.h is not big, so it shouldn't be a problem to copy it. As for > init.c, it should be either copied or moved to a more suitable place. I think it's safe to say that the only part of kern/powerpc/ieee1275/init.c that only works on PowerPC is its name ;-) Maybe it's time we move out those generic files under powerpc directory. I propose moving the following: kern/powerpc/ieee1275/init.c kern/powerpc/ieee1275/cmain.c kern/powerpc/ieee1275/openfw.c loader/powerpc/ieee1275/multiboot2.c Does that seem fine? -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)