From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Trent Piepho <xyzzy@speakeasy.org>
Cc: Adrian Bunk <bunk@kernel.org>, Hans Verkuil <hverkuil@xs4all.nl>,
v4l-dvb-maintainer@linuxtv.org,
Marcin Slusarz <marcin.slusarz@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [v4l-dvb-maintainer] 2.6.25 regression: VIDEO_DEV=y/m, I2C=n compile error
Date: Mon, 28 Jan 2008 09:49:12 -0200 [thread overview]
Message-ID: <20080128094912.1848eacd@gaivota> (raw)
In-Reply-To: <Pine.LNX.4.58.0801280053010.15635@shell4.speakeasy.net>
> Maybe the kernel headers should provide a couple macros for testing
> configs, since people get it wrong over and over again?
>
> #define CONFIG_ON(x) (defined(CONFIG_##x) || defined(CONFIG_##x##_MODULE))
> #define CONFIG_AVAIABLE(x) (defined(CONFIG_##x) || (defined(MODULE) && defined(CONFIG_##x##_MODULE)))
Seems a good idea to me.
>
> Not sure what to do about VIDEO_DEV=y, I2C=m. It should be possible except
> for this function.
I don't see much sense on allowing v4l2-common being in-kernel, while having
I2C as module. Also, creating a separate module for just a single function
seems to be overkill.
IMO, in this specific case, v4l2-common should also be a module. Not sure,
however,the better syntax on Kconfig. Once, someone suggested a very weird
syntax, like:
depends on I2C if I2C
Cheers,
Mauro
next prev parent reply other threads:[~2008-01-28 11:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-27 18:52 2.6.25 regression: VIDEO_DEV=y/m, I2C=n compile error Adrian Bunk
2008-01-28 0:33 ` Mauro Carvalho Chehab
2008-01-28 8:40 ` Adrian Bunk
2008-01-28 9:05 ` [v4l-dvb-maintainer] " Trent Piepho
2008-01-28 11:49 ` Mauro Carvalho Chehab [this message]
2008-01-28 12:12 ` Adrian Bunk
2008-01-28 12:22 ` Mauro Carvalho Chehab
2008-01-28 12:25 ` Mauro Carvalho Chehab
2008-01-29 16:38 ` Mauro Carvalho Chehab
2008-01-28 12:17 ` Jan Engelhardt
2008-01-28 12:25 ` Adrian Bunk
2008-02-01 19:24 ` Trent Piepho
2008-01-29 18:42 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080128094912.1848eacd@gaivota \
--to=mchehab@infradead.org \
--cc=bunk@kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=v4l-dvb-maintainer@linuxtv.org \
--cc=xyzzy@speakeasy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.