From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JJRWL-0007GI-Ri for mharc-grub-devel@gnu.org; Mon, 28 Jan 2008 05:47:22 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JJRWF-0007EX-Rj for grub-devel@gnu.org; Mon, 28 Jan 2008 05:47:16 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JJRW9-0007Co-QS for grub-devel@gnu.org; Mon, 28 Jan 2008 05:47:14 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JJRW9-0007Ca-FO for grub-devel@gnu.org; Mon, 28 Jan 2008 05:47:09 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JJRW9-0002ja-1B for grub-devel@gnu.org; Mon, 28 Jan 2008 05:47:09 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JJRW7-0007UX-TZ for grub-devel@gnu.org; Mon, 28 Jan 2008 11:47:08 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JJRUK-00008x-3S for grub-devel@gnu.org; Mon, 28 Jan 2008 11:45:16 +0100 Date: Mon, 28 Jan 2008 11:45:16 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080128104516.GA323@thorin> References: <20080104115318.GC3020@thorin> <20080105115220.GF19370@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: grub-fstest: debug tool for filesystem driver X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2008 10:47:17 -0000 On Sat, Jan 05, 2008 at 08:11:21PM +0800, Bean wrote: > diff --git a/conf/i386-pc.rmk b/conf/i386-pc.rmk > index 2638ee5..a25dd76 100644 > --- a/conf/i386-pc.rmk > +++ b/conf/i386-pc.rmk > @@ -59,6 +59,9 @@ sbin_UTILITIES = grub-setup grub-mkdevicemap grub-probe > ifeq ($(enable_grub_emu), yes) > sbin_UTILITIES += grub-emu > endif > +ifeq ($(enable_grub_fstest), yes) > +bin_UTILITIES += grub-fstest > +endif > > # For grub-mkimage. > grub_mkimage_SOURCES = util/i386/pc/grub-mkimage.c util/misc.c \ > @@ -121,6 +124,18 @@ grub_emu_SOURCES = commands/boot.c commands/cat.c > commands/cmp.c \ > > grub_emu_LDFLAGS = $(LIBCURSES) > > +# For grub-fstest. > +util/grub-fstest.c_DEPENDENCIES = grub_fstest_init.h > +grub_fstest_SOURCES = util/grub-fstest.c util/hostfs.c util/misc.c \ > + kern/file.c kern/device.c kern/disk.c kern/err.c kern/misc.c \ > + disk/host.c disk/loopback.c commands/hexdump.c io/gzio.c \ > + commands/blocklist.c fs/fat.c fs/ext2.c kern/parser.c \ > + kern/partition.c partmap/pc.c partmap/apple.c partmap/gpt.c \ > + fs/ufs.c fs/minix.c fs/hfs.c fs/jfs.c fs/ntfs.c kern/fs.c \ > + kern/env.c fs/fshelp.c fs/xfs.c fs/affs.c fs/sfs.c fs/hfsplus.c \ > + fs/ntfscomp.c fs/iso9660.c fs/cpio.c disk/lvm.c disk/raid.c \ > + grub_fstest_init.c > + > # Scripts. > sbin_SCRIPTS = grub-install > bin_SCRIPTS = grub-mkrescue Can we move this to common.rmk ? AFAICT, there's nothing i386-pc-specific about this. As for the list of filesystems, please reuse the filesystem chunk used on other commands; this will improve readability, ensure there are no missing components (as it has happened before), and overall improve maintainability: \ fs/affs.c fs/cpio.c fs/ext2.c fs/fat.c fs/hfs.c \ fs/hfsplus.c fs/iso9660.c fs/jfs.c fs/minix.c \ fs/ntfs.c fs/ntfscomp.c fs/reiserfs.c fs/sfs.c \ fs/ufs.c fs/xfs.c \ \ -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)