From: Mike Hommey <mh@glandium.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Matthieu Moy <Matthieu.Moy@imag.fr>,
Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>,
git mailing list <git@vger.kernel.org>
Subject: Re: How to split a patch
Date: Mon, 28 Jan 2008 11:49:33 +0100 [thread overview]
Message-ID: <20080128104932.GA20586@glandium.org> (raw)
In-Reply-To: <7vr6g2teqh.fsf@gitster.siamese.dyndns.org>
On Mon, Jan 28, 2008 at 02:40:38AM -0800, Junio C Hamano <gitster@pobox.com> wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
> > Yes, and you can do the same with "git add -i". These tools are
> > not quite nice, as they encourage a wrong workflow of committing
> > what you haven't had as a whole in the work tree. By
> > definition, you are making untested commits between your base
> > commit (that presumably was tested well) and your final commit
> > (that would also be tested well).
> > ...
> > There is no such tool yet, though.
> >
> > The splitting you can do with "rebase -i" instead walks
> > forwards. That also lets you test before you make commits in
> > each step.
>
> Having said all that, what I tend to do in practice is something
> like this:
(...)
I just git commit the hunks, then git stash the rest of the changes, and
if I need some more changes to make the hunks only work, I commit --amend.
Once the commit is stable, I stash apply, resolving conflicts if any arose.
Mike
next prev parent reply other threads:[~2008-01-28 10:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-28 9:05 How to split a patch Paolo Ciarrocchi
2008-01-28 9:25 ` Junio C Hamano
2008-01-28 9:32 ` Paolo Ciarrocchi
2008-01-28 9:47 ` Matthieu Moy
2008-01-28 10:27 ` Junio C Hamano
2008-01-28 10:40 ` Junio C Hamano
2008-01-28 10:49 ` Mike Hommey [this message]
2008-01-28 10:44 ` Wincent Colaiuta
2008-01-28 12:47 ` Johannes Schindelin
2008-01-28 10:27 ` Wincent Colaiuta
2008-01-28 10:37 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080128104932.GA20586@glandium.org \
--to=mh@glandium.org \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=paolo.ciarrocchi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.