From: Ingo Molnar <mingo@elte.hu>
To: Ian Campbell <ijc@hellion.org.uk>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCHv2 1/9] x86: Unify whitespace and comments in arch/x86/boot/compressed/vmlinux_??.lds
Date: Mon, 28 Jan 2008 12:03:33 +0100 [thread overview]
Message-ID: <20080128110333.GD32342@elte.hu> (raw)
In-Reply-To: <1201509949-3285-2-git-send-email-ijc@hellion.org.uk>
thanks Ian, i've picked up your series into x86.git.
one small nit - when doing cleanups i've been consistently using this
formatting for comments:
/*
* Be careful parts of head_32.S assume startup_32 is at
* address 0.
*/
instead of:
/* Be careful parts of head_32.S assume startup_32 is at
* address 0.
*/
(this is just personal preference, both forms are CodingStyle conform.
I like the former a bit more because it visually separates comments from
previous lines of code more. [and comments have rarely any relationship
to previous code - they apply to the following code lines.] Anyway, no
need to resend the series - just please keep this in mind for future
cleanups.)
Ingo
prev parent reply other threads:[~2008-01-28 11:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-28 8:45 Unify arch/x86/boot/compressed/{vmlinux.scr,misc.c} Ian Campbell
2008-01-28 8:45 ` [PATCHv2 1/9] x86: Unify whitespace and comments in arch/x86/boot/compressed/vmlinux_??.lds Ian Campbell
2008-01-28 8:45 ` [PATCHv2 2/9] x86: Unify whitespace in arch/x86/boot/compressed/vmlinux_??.scr Ian Campbell
2008-01-28 8:45 ` [PATCHv2 3/9] x86_64: Switch to .rodata.compressed " Ian Campbell
2008-01-28 8:45 ` [PATCHv2 4/9] x86_64: Unify arch/x86/boot/compressed/vmlinux_??.scr Ian Campbell
2008-01-28 8:45 ` [PATCHv2 5/9] x86: Unify strings in arch/x86/boot/compressed/misc_??.c Ian Campbell
2008-01-28 8:45 ` [PATCHv2 6/9] x86: Unify whitespace and comments " Ian Campbell
2008-01-28 8:45 ` [PATCHv2 7/9] x86: Unify headers " Ian Campbell
2008-01-28 8:45 ` [PATCHv2 8/9] x86: Unify variable names " Ian Campbell
2008-01-28 8:45 ` [PATCHv2 9/9] x86: Unify arch/x86/boot/compressed/misc_??.c Ian Campbell
2008-01-28 11:03 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080128110333.GD32342@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=ijc@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.