Re: [Cbe-oss-dev] Subject: cell: add spu aware cpufreq governor

[Christian Krafft <krafft@de.ibm.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1413 bytes --]

First of all, sorry for the delayed answer.

I had no hardware access (and no mail) last week,
I'll provide an updated patch very soon.

And thanks for your comments ;-)

Cheers,
Christian

On Mon, 21 Jan 2008 12:09:23 +0900 (JST)
"Akinobu Mita" <mita@fixstars.com> wrote:

> > +/*
> > + * module init and destoy
> > + */
> > +
> > +static int __init spu_gov_init(void)
> > +{
> > +if (!machine_is(cell))
> > +return -ENODEV;
> > +
> > +kspugov_wq = create_workqueue("kspugov");
> > +if (!kspugov_wq) {
> > +printk(KERN_ERR "creation of kspugov failed\n");
> > +return -EFAULT;
> > +}
> > +
> > +return cpufreq_register_governor(&spu_governor);
> 
> Missing an error handling. This line should be something like:
> 
>     err = cpufreq_register_governor(&spu_governor);
>     if (err) {
>         destroy_workqueue(kspugov_wq);
>         return err;
>     }
> 
>     return 0;
> 
> It seems like this is copied from drivers/cpufreq/cpufreq_governor.c
> Althought this is not big problem, it would be nice to fix as well.
> 
> > +}
> 
> 
> 


-- 
Mit freundlichen Gruessen,
kind regards,

Christian Krafft
IBM Systems & Technology Group,
Linux Kernel Development
IT Specialist


Vorsitzender des Aufsichtsrats:	Martin Jetter
Geschaeftsfuehrung:		Herbert Kircher
Sitz der Gesellschaft:		Boeblingen
Registriergericht:		Amtsgericht Stuttgart, HRB 243294

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 147 bytes --]

_______________________________________________
Cpufreq mailing list
Cpufreq@lists.linux.org.uk
http://lists.linux.org.uk/mailman/listinfo/cpufreq