[U-Boot-Users] [PATCH] Use `ln -sf` rather than `rm -f && ln -s`

[Mike Frysinger <vapier@gentoo.org>]

On Monday 28 January 2008, Wolfgang Denk wrote:
> In message <1201520254-25593-1-git-send-email-vapier@gentoo.org> you wrote:
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > ---
> >  tools/Makefile |    9 +++------
> >  1 files changed, 3 insertions(+), 6 deletions(-)
> >
> > diff --git a/tools/Makefile b/tools/Makefile
> > index af0de47..22d9dae 100644
> > --- a/tools/Makefile
> > +++ b/tools/Makefile
> > @@ -203,19 +203,16 @@ else
> >  endif
> >
> >  $(obj)environment.c:
> > -		@rm -f $(obj)environment.c
> > -		ln -s $(src)../common/environment.c $(obj)environment.c
> > +		ln -s -f $(src)../common/environment.c $(obj)environment.c
>
> Be careful here. Are you 100% sure that all systems in the field will
> behave exactly as your's is doing?

i really dont understand what you mean.  any POSIX compliant system will 
behave exactly as it's supposed to: if the destination exists already, unlink 
it just before creating the link.

> What is the exact problem you are trying to solve? If it's not a bug,
> I recomment to leave the code as is.

i wouldnt be posting a change if it werent causing me a problem.  as i said, 
the time between executing `rm` and `ln` is too long and can cause problems 
when building u-boot in parallel.  moving the unlink() from `rm` to `ln` just 
shortens this window drastically.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080128/d5583c8c/attachment.pgp