From: David Miller <davem@davemloft.net>
To: mchan@broadcom.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 3/7][BNX2]: Remove REG_WR_IND/REG_RD_IND macros.
Date: Tue, 29 Jan 2008 21:35:15 -0800 (PST) [thread overview]
Message-ID: <20080129.213515.125486015.davem@davemloft.net> (raw)
In-Reply-To: <1201652373.19087.12.camel@dell>
From: "Michael Chan" <mchan@broadcom.com>
Date: Tue, 29 Jan 2008 16:19:33 -0800
> [BNX2]: Remove REG_WR_IND/REG_RD_IND macros.
>
> The REG_WR_IND/REG_RD_IND macros are unnecessary and obfuscate the
> code. Many callers to these macros read and write shared memory from
> the bp->shmem_base, so we add 2 similar functions that automatically
> add the shared memory base.
>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Nice cleanup, applied.
prev parent reply other threads:[~2008-01-30 5:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 0:19 [PATCH 3/7][BNX2]: Remove REG_WR_IND/REG_RD_IND macros Michael Chan
2008-01-30 5:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080129.213515.125486015.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.