From: Dmitry Torokhov <dtor@insightbb.com>
To: eric miao <eric.y.miao@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH 1/12] pxa: rename the pxa27x_keyboard to pxa27x_keypad
Date: Tue, 29 Jan 2008 02:22:47 -0500 [thread overview]
Message-ID: <200801290222.48095.dtor@insightbb.com> (raw)
In-Reply-To: <f17812d70801282257x573f2aehd808589344f13f9d@mail.gmail.com>
On Tuesday 29 January 2008 01:57, eric miao wrote:
> On Jan 29, 2008 2:26 PM, Dmitry Torokhov <dtor@insightbb.com> wrote:
> > Hi Eric,
> >
> > On Wednesday 23 January 2008 02:16, eric miao wrote:
> > > Subject: [PATCH] pxa: rename the pxa27x_keyboard to pxa27x_keypad
> > >
> > > The controller should really be called keypad, and also align
> > > the naming of functions and structures to use "pxa27x_keypad"
> > > as prefix, instead of "pxakbd".
> >
> > Not sure what the difference is... Seems to be a gratuous renaming.
> >
>
> Yeah, though I used git-mv, the result of git-format-patch still looks horrible.
Probably if you do move commit and rename separately it will be somewhat cleaner.
> Anyway, this is just a naming issue. While other pxa drivers are slowly
> transitioning to a more standard naming convention (if you take a look at
> recent [arch/arm/mach-pxa/devices.c] in Linus's recent tree) I first update
> this to later patches could be more specific.
Let me take a look...
--
Dmitry
next prev parent reply other threads:[~2008-01-29 7:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-23 7:16 [PATCH 1/12] pxa: rename the pxa27x_keyboard to pxa27x_keypad eric miao
2008-01-29 6:26 ` Dmitry Torokhov
2008-01-29 6:57 ` eric miao
2008-01-29 7:22 ` Dmitry Torokhov [this message]
2008-01-31 3:31 ` eric miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801290222.48095.dtor@insightbb.com \
--to=dtor@insightbb.com \
--cc=eric.y.miao@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.