From: Sam Ravnborg <sam@ravnborg.org>
To: Yi Yang <yi.y.yang@intel.com>
Cc: tglx@linutronix.de, hpa@zytor.com, mingo@redhat.com,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 2.6.24] x86: add sysfs interface for cpuid module
Date: Tue, 29 Jan 2008 09:44:35 +0100 [thread overview]
Message-ID: <20080129084435.GA8962@uranus.ravnborg.org> (raw)
In-Reply-To: <1201562058.12722.9.camel@yangyi-dev.bj.intel.com>
> +
> +static struct notifier_block __cpuinitdata cpuid_sysfs_cpu_notifier = {
> + .notifier_call = cpuid_sysfs_cpu_callback,
> +};
Data is annotated _cpuintidata
but
> +
Data is annotated _cpuintidata
> @@ -217,11 +445,14 @@ static void __exit cpuid_exit(void)
> {
> int cpu = 0;
>
> - for_each_online_cpu(cpu)
> + for_each_online_cpu(cpu) {
> cpuid_device_destroy(cpu);
> + remove_cpuid_sysfs(cpu);
> + }
> class_destroy(cpuid_class);
> unregister_chrdev(CPUID_MAJOR, "cpu/cpuid");
> unregister_hotcpu_notifier(&cpuid_class_cpu_notifier);
> + unregister_hotcpu_notifier(&cpuid_sysfs_cpu_notifier);
used in an __exit function.
You should have seen a Section mismatch warning for this.
The right fix is to annotate the cpuid_sysfs_cpu_notifier
with __initdata_refok (soon to be named __refdata)
Or even better to declare it const and use _refconst.
Sam
next prev parent reply other threads:[~2008-01-29 8:44 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-04 10:10 [linux-pm][PATCH] base: Change power/wakeup output from "" to "unsupported" if wakeup feature isn't supported by a device Yi Yang
2008-01-04 11:48 ` Pavel Machek
2008-01-04 16:09 ` [PATCH] " David Brownell
2008-01-04 16:09 ` [linux-pm][PATCH] " David Brownell
2008-01-04 16:38 ` Alan Stern
2008-01-04 16:52 ` [PATCH] " Olivier Galibert
2008-01-04 16:52 ` [linux-pm][PATCH] " Olivier Galibert
2008-01-04 17:20 ` [PATCH] " Oliver Neukum
2008-01-04 17:20 ` [linux-pm][PATCH] " Oliver Neukum
2008-01-07 2:00 ` [PATCH] " Yi Yang
2008-01-07 2:00 ` [linux-pm][PATCH] " Yi Yang
2008-01-07 1:55 ` Yi Yang
2008-01-07 3:49 ` David Brownell
2008-01-07 3:49 ` [PATCH] " David Brownell
2008-01-07 1:55 ` Yi Yang
2008-01-07 1:52 ` [linux-pm][PATCH] " Yi Yang
2008-01-07 1:52 ` [PATCH] " Yi Yang
2008-01-04 16:38 ` Alan Stern
2008-01-07 1:37 ` [linux-pm][PATCH] " Yi Yang
2008-01-07 1:57 ` Rafael J. Wysocki
2008-01-07 2:05 ` [PATCH] " Yi Yang
2008-01-07 2:05 ` [linux-pm][PATCH] " Yi Yang
2008-01-07 16:46 ` Rafael J. Wysocki
2008-01-07 16:46 ` [PATCH] " Rafael J. Wysocki
2008-01-07 1:57 ` Rafael J. Wysocki
2008-01-07 1:37 ` Yi Yang
2008-01-07 1:21 ` Yi Yang
2008-01-07 1:21 ` [linux-pm][PATCH] " Yi Yang
2008-01-04 11:48 ` [PATCH] " Pavel Machek
2008-01-04 16:31 ` [linux-pm][PATCH] " David Brownell
2008-01-07 1:51 ` Yi Yang
2008-01-07 1:51 ` [PATCH] " Yi Yang
2008-01-04 16:31 ` David Brownell
2008-01-22 23:05 ` [PATCH 2.6.24-rc8] cpufreq: fix obvious condition statement error Yi Yang
2008-01-22 23:05 ` Yi Yang
2008-01-28 23:14 ` [PATCH 2.6.24] x86: add sysfs interface for cpuid module Yi Yang
2008-01-29 8:44 ` Sam Ravnborg [this message]
2008-01-29 22:22 ` Yi Yang
2008-01-30 7:48 ` Sam Ravnborg
2008-01-29 15:51 ` H. Peter Anvin
2008-01-29 17:52 ` Yi Yang
2008-01-30 6:09 ` H. Peter Anvin
2008-01-29 21:56 ` Yi Yang
2008-01-30 7:17 ` H. Peter Anvin
2008-01-29 22:13 ` Yi Yang
2008-01-30 7:33 ` H. Peter Anvin
2008-01-29 23:41 ` [RFC PATCH 2.6.24] x86: add sysfs interface for cpuid module, try 2 Yi Yang
2008-01-30 17:35 ` H. Peter Anvin
2008-01-31 1:18 ` [PATCH 2.6.24] Add new string functions real_strtoul and change kernel params to use them Yi Yang
2008-01-31 17:03 ` Randy Dunlap
2008-01-31 16:30 ` Yi Yang
2008-02-01 2:47 ` Randy Dunlap
2008-01-31 22:11 ` [PATCH 2.6.24] Add new string functions strict_strto* and convert kernel params to use them, take 2 Yi Yang
2008-02-01 0:02 ` [PATCH 2.6.24] Add new string functions strict_strto* and convert kernel params to use them, take 3 Yi Yang
2008-02-01 7:36 ` [PATCH 2.6.24] Add new string functions strict_strto* and convert kernel params to use them, take 2 Andrew Morton
2008-02-01 7:39 ` Andrew Morton
2008-02-01 7:40 ` Andrew Morton
2008-02-01 16:31 ` [PATCH 2.6.24] x86: add sysfs interface for cpuid module dean gaudet
2008-02-01 17:56 ` H. Peter Anvin
2008-02-01 17:58 ` H. Peter Anvin
2008-02-14 23:44 ` [PATCH 2.6.25-rc1] cpufreq: fix cpufreq policy refcount imbalance Yi Yang
2008-02-14 23:44 ` Yi Yang
2008-02-14 23:48 ` Yi Yang
2008-02-14 23:48 ` Yi Yang
2008-02-15 15:52 ` Alan Stern
2008-02-15 15:52 ` [linux-pm] " Alan Stern
2008-02-15 15:52 ` Alan Stern
2008-02-15 18:24 ` Greg KH
2008-02-15 18:24 ` Greg KH
2008-02-15 21:01 ` Greg KH
2008-02-15 21:01 ` Greg KH
2008-02-25 0:46 ` [PATCH 2.6.25-rc3] cpuidle: fix cpuidle time and usage overflow Yi Yang
2008-02-25 0:46 ` Yi Yang
2008-02-25 10:15 ` Ingo Molnar
2008-02-25 10:15 ` Ingo Molnar
2008-02-25 1:10 ` Yi Yang
2008-02-25 1:10 ` Yi Yang
2008-03-26 4:46 ` Len Brown
2008-03-26 4:46 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080129084435.GA8962@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=yi.y.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.