From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JJmcv-000339-90 for mharc-grub-devel@gnu.org; Tue, 29 Jan 2008 04:19:33 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JJmct-00032h-68 for grub-devel@gnu.org; Tue, 29 Jan 2008 04:19:31 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JJmcs-00032D-D1 for grub-devel@gnu.org; Tue, 29 Jan 2008 04:19:30 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JJmcs-000329-3t for grub-devel@gnu.org; Tue, 29 Jan 2008 04:19:30 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JJmcr-0005iv-1j for grub-devel@gnu.org; Tue, 29 Jan 2008 04:19:29 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JJmcm-00015v-RO for grub-devel@gnu.org; Tue, 29 Jan 2008 10:19:28 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JJmb2-00081E-Q7 for grub-devel@gnu.org; Tue, 29 Jan 2008 10:17:36 +0100 Date: Tue, 29 Jan 2008 10:17:36 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080129091736.GG30048@thorin> References: <20080128160905.GA2739@saphi> <20080128165504.GB9715@thorin> <20080129051252.GA2504@saphi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20080129051252.GA2504@saphi> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: IA64 port X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jan 2008 09:19:31 -0000 On Tue, Jan 29, 2008 at 06:12:52AM +0100, Tristan Gingold wrote: > > Have you checked if this trick works on other ports? Maybe it'd be a good idea > > to merge this first. > > I don't really understand what do you mean by 'works on other ports'. It is > designed to be an optionnal feature used only by ia64. Nothing IA64 specific > and other ports may use it. If we go this way, it would be good to slightly > improve it. I suggest you just make sure it'll be usable on other ports in case a need arises, without going out of your way to support it. > > > +GRUB_MOD_INIT(linux_normal) > > > +{ > > > + (void) mod; /* To stop warning. */ > > > + grub_register_command > > > + ("linux", grub_normal_linux_command, > > > + GRUB_COMMAND_FLAG_BOTH | GRUB_COMMAND_FLAG_NO_ARG_PARSE, > > > + "linux FILE [ARGS...]", > > > + "Load a linux kernel.", 0); > > > + > > > + grub_register_command > > > + ("initrd", grub_normal_initrd_command, > > > + GRUB_COMMAND_FLAG_BOTH | GRUB_COMMAND_FLAG_NO_ARG_PARSE, > > > + "initrd FILE", > > > + "Load an initrd.", 0); > > > + > > > + grub_register_command > > > + ("module", grub_normal_cmd_module, > > > + GRUB_COMMAND_FLAG_BOTH | GRUB_COMMAND_FLAG_NO_ARG_PARSE, > > > + "module FILE [ARGS...]", > > > + "Load a Multiboot module.", 0); > > > > Multiboot module loader in linux_normal.mod ? > > Well, well well. Long question :-) > > Ia64 doesn't really fit in multiboot: it's a full 64 bits processor, But there's multiboot2. > there > may be no room for an header in the 8KB (or you have to waste a lot of memory > to keep alignment), no room for EFI pointers in the header and no Ia64 OS > uses it. Well this were my conclusion when I read MB specs. Does this affect only EFI, or ia64 in general (e.g. ia64-coreboot, when that exists) ? Also note the string "Load a Multiboot module." is present. If this is not multiboot, I'd suggest renaming the command to avoid name collisions (not only if multiboot is added later, but also user confusion). > > > diff -ruNp -x '*~' -x CVS grub2.orig/util/ia64/efi/elf2pe.c grub2/util/ia64/efi/elf2pe.c > > > --- grub2.orig/util/ia64/efi/elf2pe.c 1970-01-01 01:00:00.000000000 +0100 > > > +++ grub2/util/ia64/efi/elf2pe.c 2008-01-28 16:29:58.000000000 +0100 > [...] > > > > This utility seems to be usable on i386 too? In that case, better to put it > > outside ia64/ dir? > > It should work on i386 too, but not tested. > I have written this utility for my port of EFI and adapted the style for > grub. It may be nice to share this code with i386 but not really required > now IMHO. util/i386/efi/grub-mkimage.c already generates PE, right? Why a different way to handle this? Sound like it'd be more consistent to either use elf2pe on both or share the same grub-mkimage. What do you think? -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)