Re: kernel BUG at drivers/block/cciss.c:1260! (with recent linux-2.6 tree)

[Jens Axboe <jens.axboe@oracle.com>]

On Tue, Jan 29 2008, Jens Axboe wrote:
> On Tue, Jan 29 2008, Andrew Vasquez wrote:
> > Hitting a consistent BUG() with recent Linus' linux-2.6.git:
> > 
> > 	[   12.941428] ------------[ cut here ]------------
> > 	[   12.944874] kernel BUG at drivers/block/cciss.c:1260!
> > 	[   12.944874] invalid opcode: 0000 [1] SMP 
> > 	[   12.944874] CPU 0 
> > 	[   12.944874] Modules linked in:
> > 	[   12.944874] Pid: 0, comm: swapper Not tainted 2.6.24 #43
> > 	[   12.944874] RIP: 0010:[<ffffffff8039e43d>]  [<ffffffff8039e43d>] cciss_softirq_done+0xbc/0x1bf
> > 	[   12.944874] RSP: 0018:ffffffff8063aed0  EFLAGS: 00010202
> > 	[   12.944874] RAX: 0000000000000001 RBX: ffff8100cf800010 RCX: ffff81042f1253b0
> > 	[   12.944874] RDX: ffff81042de398f0 RSI: ffff81042de398f0 RDI: 0000000000000001
> > 	[   12.944874] RBP: ffff81042daa0000 R08: ffff81042f1253b0 R09: 0000000000000001
> > 	[   12.944874] R10: 00000000000000fe R11: 0000000000000000 R12: 0000000000000002
> > 	[   12.944874] R13: 0000000000000001 R14: ffff8100cf800000 R15: ffff81042de398f0
> > 	[   12.944874] FS:  0000000000000000(0000) GS:ffffffff805bb000(0000) knlGS:0000000000000000
> > 	[   12.944874] CS:  0010 DS: 0018 ES: 0018 CR0: 000000008005003b
> > 	[   12.944874] CR2: 00002afed7eea340 CR3: 000000042dbba000 CR4: 00000000000006e0
> > 	[   12.944874] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> > 	[   12.944874] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
> > 	[   12.944874] Process swapper (pid: 0, threadinfo ffffffff805f4000, task ffffffff805624a0)
> > 	[   12.944874] Stack:  0000000000000000 ffffffff8063af10 0000000000000001 ffffffff80632d60
> > 	[   12.944874]  0000000000000000 000000000000000a ffffffff805bb900 ffffffff8032038f
> > 	[   12.944874]  ffffffff8063af10 ffffffff8063af10 ffffffff805bb940 ffffffff802346b4
> > 	[   12.944874] Call Trace:
> > 	[   12.944874]  <IRQ>  [<ffffffff8032038f>] blk_done_softirq+0x69/0x78
> > 	[   12.944874]  [<ffffffff802346b4>] __do_softirq+0x6f/0xd8
> > 	[   12.944874]  [<ffffffff8020c45c>] call_softirq+0x1c/0x30
> > 	[   12.944874]  [<ffffffff8020e347>] do_softirq+0x30/0x80
> > 	[   12.944874]  [<ffffffff8020e409>] do_IRQ+0x72/0xd9
> > 	[   12.944874]  [<ffffffff8020a50a>] mwait_idle+0x0/0x46
> > 	[   12.944874]  [<ffffffff8020a3da>] default_idle+0x0/0x3d
> > 	[   12.944874]  [<ffffffff8020b7e1>] ret_from_intr+0x0/0xa
> > 	[   12.944874]  <EOI>  [<ffffffff8020a54c>] mwait_idle+0x42/0x46
> > 	[   12.944874]  [<ffffffff8020a481>] cpu_idle+0x6a/0xae
> > 	[   12.944874] 
> > 	[   12.944874] 
> > 	[   12.944874] Code: 0f 0b eb fe 48 8d 85 d8 c0 00 00 48 89 04 24 48 89 c7 e8 e5 
> > 	[   12.944874] RIP  [<ffffffff8039e43d>] cciss_softirq_done+0xbc/0x1bf
> > 	[   12.944874]  RSP <ffffffff8063aed0>
> > 	[   12.944903] ---[ end trace e9c631603f90d22f ]---
> 
> Thanks, will take a look.

Andrew, can you try with this applied?

diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index ef50068..bd7b352 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -1257,7 +1257,7 @@ static void cciss_softirq_done(struct request *rq)
 #endif				/* CCISS_DEBUG */
 
 	if (blk_end_request(rq, (rq->errors == 0) ? 0 : -EIO, blk_rq_bytes(rq)))
-		BUG();
+		blk_dump_rq_flags(rq, "cciss rq");
 
 	spin_lock_irqsave(&h->lock, flags);
 	cmd_free(h, cmd, 1);

-- 
Jens Axboe