All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tristan Gingold <tgingold@free.fr>
To: Marco Gerards <mgerards@xs4all.nl>
Cc: tgingold@free.fr, The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: IA64 port
Date: Wed, 30 Jan 2008 06:57:34 +0100	[thread overview]
Message-ID: <20080130055734.GD4665@saphi> (raw)
In-Reply-To: <871w80adut.fsf@xs4all.nl>

On Tue, Jan 29, 2008 at 03:46:50PM +0100, Marco Gerards wrote:
> Robert suggested some changes.  I also noticed in the discussion that
> you didn't follow common practise (like an existing grub-mkimage
> implementation).  Personally, as maintainer, I am against maintaining
> two different approaches of the same problem.  It costs us time to
> maintain this and both case have separate bugs.  So I rather see the
> code shared, one way or the other.  To safe time, it might save you
> some work if you initiate a discussion about this.

The facts:

util/i386/efi/grub-mkimage.c and elf2pe.c do almost the same thing: converting
an ELF file to a PE file.  But:

* the input format is slightly different (Elf32 vs Elf64)
* the output format is slightly different (PE vs PE+)
* the relocating work is different (x86 vs ia64, Rel vs Rela)
* The entry point is a descriptor on ia64
* grub-mkimage.c can insert modules in a section.

I propose to extend grub-mkimage.c so that it can handle ia64.  I propose to
select at compile time which convertion to do through macro (see beginning
of elf2pe file to see an example).  I don't think it is worth making a
generic grub-mkimage binary that can do any convertion: it's too much
code duplication.

Ok for this approach ?

Tristan. 



  parent reply	other threads:[~2008-01-30  5:50 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-28 16:09 IA64 port Tristan Gingold
2008-01-28 16:55 ` Robert Millan
2008-01-29  5:12   ` Tristan Gingold
2008-01-29  9:17     ` Robert Millan
2008-01-29 10:31       ` tgingold
2008-01-29 11:08         ` Robert Millan
2008-01-29  9:59     ` Robert Millan
2008-01-29 10:35       ` tgingold
2008-01-29 11:32         ` Robert Millan
2008-01-29 12:56           ` tgingold
2008-01-29 13:19             ` Robert Millan
2008-01-29 14:46               ` Marco Gerards
2008-01-29 15:30                 ` Robert Millan
2008-01-29 16:38                   ` tgingold
2008-01-29 18:48                     ` Robert Millan
2008-01-30  5:23                       ` Tristan Gingold
2008-01-30 13:19                         ` Robert Millan
2008-01-29 16:35                 ` tgingold
2008-01-30  5:48                 ` Tristan Gingold
2008-01-30 15:07                   ` Robert Millan
2008-01-30 15:33                     ` Robert Millan
2008-01-30 16:22                     ` tgingold
2008-01-30 18:38                       ` Robert Millan
2008-02-04 15:45                   ` Marco Gerards
2008-02-04 16:07                     ` Robert Millan
2008-02-05  9:51                       ` tgingold
2008-02-10 22:43                   ` Alexandre Boeglin
2008-02-11  8:59                     ` tgingold
2010-01-18 18:03                   ` Robert Millan
2008-01-30  5:48                 ` Tristan Gingold
2008-01-30  5:57                 ` Tristan Gingold [this message]
2008-01-30 13:25                   ` Robert Millan
2008-01-30 16:04                     ` tgingold
2008-03-19 17:11                       ` Robert Millan
2008-03-20  6:34                         ` Tristan Gingold
2008-02-05 22:49       ` Alexandre Boeglin
2008-01-29  5:49   ` Tristan Gingold
2008-01-29  9:08     ` Robert Millan
2008-01-29 10:10       ` tgingold
2008-01-29 11:07         ` Robert Millan
2008-01-29 12:53           ` tgingold
2008-01-29 13:39             ` Robert Millan
2008-01-29 13:36     ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080130055734.GD4665@saphi \
    --to=tgingold@free.fr \
    --cc=grub-devel@gnu.org \
    --cc=mgerards@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.