From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JKCyn-0006Sc-0F for mharc-grub-devel@gnu.org; Wed, 30 Jan 2008 08:27:53 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JKCyl-0006SB-3j for grub-devel@gnu.org; Wed, 30 Jan 2008 08:27:51 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JKCyj-0006Rt-LK for grub-devel@gnu.org; Wed, 30 Jan 2008 08:27:50 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JKCyj-0006Rk-GA for grub-devel@gnu.org; Wed, 30 Jan 2008 08:27:49 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JKCyi-0000VM-I3 for grub-devel@gnu.org; Wed, 30 Jan 2008 08:27:49 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JKCya-000479-4e; Wed, 30 Jan 2008 14:27:41 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JKCwx-00041u-AL; Wed, 30 Jan 2008 14:25:59 +0100 Date: Wed, 30 Jan 2008 14:25:59 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080130132559.GA15395@thorin> References: <20080128160905.GA2739@saphi> <20080128165504.GB9715@thorin> <20080129051252.GA2504@saphi> <20080129095922.GA31756@thorin> <1201602926.479f016e27f08@imp.free.fr> <20080129113219.GA22894@thorin> <1201611409.479f22918bed6@imp.free.fr> <20080129131934.GB26291@thorin> <871w80adut.fsf@xs4all.nl> <20080130055734.GD4665@saphi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20080130055734.GD4665@saphi> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Cc: tgingold@free.fr Subject: Re: IA64 port X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2008 13:27:51 -0000 On Wed, Jan 30, 2008 at 06:57:34AM +0100, Tristan Gingold wrote: > On Tue, Jan 29, 2008 at 03:46:50PM +0100, Marco Gerards wrote: > > Robert suggested some changes. I also noticed in the discussion that > > you didn't follow common practise (like an existing grub-mkimage > > implementation). Personally, as maintainer, I am against maintaining > > two different approaches of the same problem. It costs us time to > > maintain this and both case have separate bugs. So I rather see the > > code shared, one way or the other. To safe time, it might save you > > some work if you initiate a discussion about this. > > The facts: > > util/i386/efi/grub-mkimage.c and elf2pe.c do almost the same thing: converting > an ELF file to a PE file. But: > > * the input format is slightly different (Elf32 vs Elf64) > * the output format is slightly different (PE vs PE+) > * the relocating work is different (x86 vs ia64, Rel vs Rela) > * The entry point is a descriptor on ia64 > * grub-mkimage.c can insert modules in a section. Sounds like they're very different. Maybe it'd be fine to just change the name and user interface from elf2pe.c to util/ia64/efi/grub-mkimage.c ? What do you think? -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)