From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: grub2 resets machine when reading from an xfs filesystem
Date: Wed, 30 Jan 2008 14:43:16 +0100 [thread overview]
Message-ID: <20080130134316.GA15861@thorin> (raw)
In-Reply-To: <ca0f59980801300217n748009abvfe4d3327c9f93136@mail.gmail.com>
On Wed, Jan 30, 2008 at 06:17:18PM +0800, Bean wrote:
> I figure it out, the problem is caused by nested function:
>
> int call_hook (grub_uint64_t ino, char *filename)
>
> it would take 3 registry to pass the parameter ! (2 for ino), so %ecx
> will be overwritten agian.
>
> NESTED_FUNC_ATTR doesn't help, because there is only 2 parameters
> here, so you need to use __attribute__ ((regparm (1))) explicitly.
Cool. I wonder, how do you manage to catch this kind of things. Do you
use a debugger in qemu, or just read the code and then you see it :-) ?
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)
prev parent reply other threads:[~2008-01-30 13:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080129115843.3620.68940.reportbug@neasden.st-albans.poggs.net>
[not found] ` <20080129122733.GA24823@thorin>
[not found] ` <20080129124316.GC18831@tufnell.london.poggs.net>
[not found] ` <20080129132922.GC26291@thorin>
[not found] ` <20080129144733.GF18831@tufnell.london.poggs.net>
[not found] ` <20080129151529.GB3869@thorin>
[not found] ` <20080129155021.GG18831@tufnell.london.poggs.net>
[not found] ` <20080129183005.GC12993@thorin>
[not found] ` <479F8A02.9050901@poggs.co.uk>
[not found] ` <20080129212257.GA4487@thorin>
2008-01-29 21:34 ` grub2 resets machine when reading from an xfs filesystem Peter Hicks
[not found] ` <479F9B60.1080509@poggs.co.uk>
2008-01-29 21:39 ` Robert Millan
2008-01-30 7:11 ` Bean
2008-01-30 10:17 ` Bean
2008-01-30 12:08 ` Marco Gerards
2008-01-30 12:36 ` Bean
2008-01-30 15:02 ` Marco Gerards
2008-02-01 11:36 ` Yoshinori K. Okuji
2008-02-01 11:48 ` Robert Millan
2008-02-01 12:02 ` Marco Gerards
2008-01-30 13:43 ` Robert Millan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080130134316.GA15861@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.