From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Christoph Egger" <Christoph.Egger@amd.com>
Subject: Re: [PATCH][ioemu] strip tap subtype prefix from image name
Date: Wed, 30 Jan 2008 14:07:50 +0100
Message-ID: <200801301407.51163.Christoph.Egger@amd.com>
References: <47A07434.1060900@novell.com>
Mime-Version: 1.0
Content-Type: text/plain;
 charset=iso-8859-15
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <47A07434.1060900@novell.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
Cc: Pat Campbell <plc@novell.com>
List-Id: xen-devel@lists.xenproject.org

On Wednesday 30 January 2008 13:57:24 Pat Campbell wrote:
> Currently I am not able to mount or boot from an HVM CDROM when it is
> configured for 'tap:aio' instead of 'file'.
>
> disk=3D[ 'tap:aio:/var/lib/xen/images/sles10-sp2-fv/disk0,hda,w', '
>        tap:aio:/home/iso/sles/SLES10.iso,hdc:cdrom,r', ]
>
> With the attached patch I am able to boot from the CDROM and or mount it.
>
> Patch changes xenstore.c:xenstore_process_event() to strip the tap subtype
> prefix from the image name.
>
> Please apply to xen-unstable tip.
>
> Signed-off-by: Pat Campbell <plc@novell.com>

Please use a more readable coding style.

What you did is this:

if (a) {
        if (b) {
                if (c) {
                        /* do it */
                } else {
                        /* Alternative C */
                }=20
        } else {
                /* Alternative B */
        }
} else {
        /* Alternative A */
}
return;



I suggest you to use this style:

if (!a) {
    /* Alternative A */
    return;
}
if (!b) {
    /* Alternative B */
    return;
}
if (!c) {
    /* Alternative C */
    return;
}
/* do it */
return;



=2D-=20
AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Gesch=E4ftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplement=E4r:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Gesch=E4ftsf=FChrer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy