All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Adrian Bunk <bunk@kernel.org>
Cc: Arjan van de Ven <arjan@linux.intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: arch/x86/kernel/test_nx.c compile error
Date: Wed, 30 Jan 2008 20:08:56 +0100	[thread overview]
Message-ID: <20080130190856.GA4221@elte.hu> (raw)
In-Reply-To: <20080130190004.GG29368@does.not.exist>


* Adrian Bunk <bunk@kernel.org> wrote:

> > +#ifdef CONFIG_X86_32
> > +		"	.long 0b\n"
> > +		"	.long 2b\n"
> > +#endif
> >  		"	.quad 0b\n"
> >  		"	.quad 2b\n"
> > +#else
> >...
> 
> You don't test whether your patches compile?  ;-)

i did - but i didnt test whether i sent you the right, fixed one :-)

> After the obvious fix it compiled.
> 
> Why wasn't this issue found before it entered Linus' tree?

because it was a relatively late patch and TEST_NX is dependent on a 
modular build - which i dont test that often. I found and fixed a mirror 
image bug in test_rodata.c.

	Ingo

  reply	other threads:[~2008-01-30 19:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-30 18:25 arch/x86/kernel/test_nx.c compile error Adrian Bunk
2008-01-30 18:42 ` Ingo Molnar
2008-01-30 18:44   ` Ingo Molnar
2008-01-30 18:59     ` Ingo Molnar
2008-01-30 19:00     ` Adrian Bunk
2008-01-30 19:08       ` Ingo Molnar [this message]
2008-01-30 19:06     ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080130190856.GA4221@elte.hu \
    --to=mingo@elte.hu \
    --cc=arjan@linux.intel.com \
    --cc=bunk@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.