From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JKL1t-0006jE-Ed for mharc-grub-devel@gnu.org; Wed, 30 Jan 2008 17:03:37 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JKL1r-0006g1-S7 for grub-devel@gnu.org; Wed, 30 Jan 2008 17:03:35 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JKL1p-0006bJ-RR for grub-devel@gnu.org; Wed, 30 Jan 2008 17:03:35 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JKL1p-0006ax-NV for grub-devel@gnu.org; Wed, 30 Jan 2008 17:03:33 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JKL1p-0008Gi-24 for grub-devel@gnu.org; Wed, 30 Jan 2008 17:03:33 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JKL1n-0004tM-Qy for grub-devel@gnu.org; Wed, 30 Jan 2008 23:03:32 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JKL0F-0001mC-3c for grub-devel@gnu.org; Wed, 30 Jan 2008 23:01:55 +0100 Date: Wed, 30 Jan 2008 23:01:55 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080130220155.GA6731@thorin> References: <87prvmm4i2.fsf@xs4all.nl> <87y7a7i4bx.fsf@xs4all.nl> <20080130184423.GB32727@thorin> <87prvjhy9p.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87prvjhy9p.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: PCI support X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2008 22:03:36 -0000 On Wed, Jan 30, 2008 at 09:08:34PM +0100, Marco Gerards wrote: > Robert Millan writes: > > > On Wed, Jan 30, 2008 at 06:57:38PM +0100, Marco Gerards wrote: > >> Marco Gerards writes: > >> > >> > 2009-01-28 Marco Gerards > >> > > >> > * bus/pci.c: New file. > >> > > >> > * include/grub/pci.h: Likewise. > >> > > >> > * include/grub/i386/pc/pci.h: Likewise. > >> > > >> > * commands/lspci.c: Likewise. > >> > > >> > * conf/i386-pc.rmk (pkglib_MODULES): Add `pci.mod' and > >> > `lspci.mod'. > >> > (pci_mod_SOURCES): New variable. > >> > (pci_mod_CFLAGS): Likewise. > >> > (pci_mod_LDFLAGS): Likewise. > >> > (lspci_mod_SOURCES): Likewise. > >> > (lspci_mod_CFLAGS): Likewise. > >> > (lspci_mod_LDFLAGS): Likewise. > >> > >> No objections? Did everyone have a (quick) look at the interfaces? > > > > You put grub_pci_read() in an arch-specific file; is that function really > > arch-specific, or only its IO addresses are? > > IO addresses are Intel only, AFAIK. Almost all architectures have > mmapped IO. It's really arch specific. Are you sure that makes grub_inl / grub_outl arch-specific ? They can't be implemented as wrappers for direct memory access? -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)