All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com>
To: Andrea Arcangeli <andrea@qumranet.com>
Cc: Robin Holt <holt@sgi.com>, Avi Kivity <avi@qumranet.com>,
	Izik Eidus <izike@qumranet.com>
Cc: kvm-devel@lists.sourceforge.net
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: steiner@sgi.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: daniel.blueman@quadrics.com
Subject: [patch 3/3] mmu_notifier: invalidate_page callbacks
Date: Wed, 30 Jan 2008 20:57:53 -0800	[thread overview]
Message-ID: <20080131045813.016961450@sgi.com> (raw)
In-Reply-To: 20080131045750.855008281@sgi.com

[-- Attachment #1: mmu_invalidate_page_rmap_callbacks --]
[-- Type: text/plain, Size: 3850 bytes --]

Callbacks to remove individual pages as done in rmap code

3 types of callbacks are used:

1. invalidate_page mmu_notifier
	Called from the inner loop of rmap walks to invalidate
	pages.

2. invalidate_page mmu_rmap_notifier
	Called after the Linux rmap loop under PageLock to allow
	a device to scan its own rmaps and remove mappings.

3. mmu_notifier_age_page
	Called for the determination of the page referenced
	status.

The callbacks occur after the Linux rmaps have been walked. A device
driver does not have to support type 1 and 2 callbacks. One is sufficient.
If we do not care about page referenced status then callback #3 can also
be omitted.

Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Robin Holt <holt@sgi.com>

---
 mm/rmap.c |   22 +++++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)

Index: linux-2.6/mm/rmap.c
===================================================================
--- linux-2.6.orig/mm/rmap.c	2008-01-30 20:03:03.000000000 -0800
+++ linux-2.6/mm/rmap.c	2008-01-30 20:17:22.000000000 -0800
@@ -49,6 +49,7 @@
 #include <linux/rcupdate.h>
 #include <linux/module.h>
 #include <linux/kallsyms.h>
+#include <linux/mmu_notifier.h>
 
 #include <asm/tlbflush.h>
 
@@ -284,7 +285,8 @@ static int page_referenced_one(struct pa
 	if (!pte)
 		goto out;
 
-	if (ptep_clear_flush_young(vma, address, pte))
+	if (ptep_clear_flush_young(vma, address, pte) |
+	    mmu_notifier_age_page(mm, address))
 		referenced++;
 
 	/* Pretend the page is referenced if the task has the
@@ -434,6 +436,7 @@ static int page_mkclean_one(struct page 
 
 		flush_cache_page(vma, address, pte_pfn(*pte));
 		entry = ptep_clear_flush(vma, address, pte);
+		mmu_notifier(invalidate_page, mm, address);
 		entry = pte_wrprotect(entry);
 		entry = pte_mkclean(entry);
 		set_pte_at(mm, address, pte, entry);
@@ -473,6 +476,10 @@ int page_mkclean(struct page *page)
 		struct address_space *mapping = page_mapping(page);
 		if (mapping) {
 			ret = page_mkclean_file(mapping, page);
+			if (unlikely(PageExternalRmap(page))) {
+				mmu_rmap_notifier(invalidate_page, page);
+				ClearPageExternalRmap(page);
+			}
 			if (page_test_dirty(page)) {
 				page_clear_dirty(page);
 				ret = 1;
@@ -677,7 +684,8 @@ static int try_to_unmap_one(struct page 
 	 * skipped over this mm) then we should reactivate it.
 	 */
 	if (!migration && ((vma->vm_flags & VM_LOCKED) ||
-			(ptep_clear_flush_young(vma, address, pte)))) {
+			(ptep_clear_flush_young(vma, address, pte) |
+				mmu_notifier_age_page(mm, address)))) {
 		ret = SWAP_FAIL;
 		goto out_unmap;
 	}
@@ -685,6 +693,7 @@ static int try_to_unmap_one(struct page 
 	/* Nuke the page table entry. */
 	flush_cache_page(vma, address, page_to_pfn(page));
 	pteval = ptep_clear_flush(vma, address, pte);
+	mmu_notifier(invalidate_page, mm, address);
 
 	/* Move the dirty bit to the physical page now the pte is gone. */
 	if (pte_dirty(pteval))
@@ -809,12 +818,14 @@ static void try_to_unmap_cluster(unsigne
 		page = vm_normal_page(vma, address, *pte);
 		BUG_ON(!page || PageAnon(page));
 
-		if (ptep_clear_flush_young(vma, address, pte))
+		if (ptep_clear_flush_young(vma, address, pte) |
+		    mmu_notifier_age_page(mm, address))
 			continue;
 
 		/* Nuke the page table entry. */
 		flush_cache_page(vma, address, pte_pfn(*pte));
 		pteval = ptep_clear_flush(vma, address, pte);
+		mmu_notifier(invalidate_page, mm, address);
 
 		/* If nonlinear, store the file page offset in the pte. */
 		if (page->index != linear_page_index(vma, address))
@@ -971,6 +982,11 @@ int try_to_unmap(struct page *page, int 
 	else
 		ret = try_to_unmap_file(page, migration);
 
+	if (unlikely(PageExternalRmap(page))) {
+		mmu_rmap_notifier(invalidate_page, page);
+		ClearPageExternalRmap(page);
+	}
+
 	if (!page_mapped(page))
 		ret = SWAP_SUCCESS;
 	return ret;

-- 

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Lameter <clameter-sJ/iWh9BUns@public.gmane.org>
To: Andrea Arcangeli <andrea-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: Peter Zijlstra
	<a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public.gmane.org>,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	steiner-sJ/iWh9BUns@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>,
	kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	daniel.blueman-xqY44rlHlBpWk0Htik3J/w@public.gmane.org,
	Robin Holt <holt-sJ/iWh9BUns@public.gmane.org>
Subject: [patch 3/3] mmu_notifier: invalidate_page callbacks
Date: Wed, 30 Jan 2008 20:57:53 -0800	[thread overview]
Message-ID: <20080131045813.016961450@sgi.com> (raw)
In-Reply-To: 20080131045750.855008281@sgi.com

[-- Attachment #1: mmu_invalidate_page_rmap_callbacks --]
[-- Type: text/plain, Size: 4122 bytes --]

Callbacks to remove individual pages as done in rmap code

3 types of callbacks are used:

1. invalidate_page mmu_notifier
	Called from the inner loop of rmap walks to invalidate
	pages.

2. invalidate_page mmu_rmap_notifier
	Called after the Linux rmap loop under PageLock to allow
	a device to scan its own rmaps and remove mappings.

3. mmu_notifier_age_page
	Called for the determination of the page referenced
	status.

The callbacks occur after the Linux rmaps have been walked. A device
driver does not have to support type 1 and 2 callbacks. One is sufficient.
If we do not care about page referenced status then callback #3 can also
be omitted.

Signed-off-by: Christoph Lameter <clameter-sJ/iWh9BUns@public.gmane.org>
Signed-off-by: Robin Holt <holt-sJ/iWh9BUns@public.gmane.org>

---
 mm/rmap.c |   22 +++++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)

Index: linux-2.6/mm/rmap.c
===================================================================
--- linux-2.6.orig/mm/rmap.c	2008-01-30 20:03:03.000000000 -0800
+++ linux-2.6/mm/rmap.c	2008-01-30 20:17:22.000000000 -0800
@@ -49,6 +49,7 @@
 #include <linux/rcupdate.h>
 #include <linux/module.h>
 #include <linux/kallsyms.h>
+#include <linux/mmu_notifier.h>
 
 #include <asm/tlbflush.h>
 
@@ -284,7 +285,8 @@ static int page_referenced_one(struct pa
 	if (!pte)
 		goto out;
 
-	if (ptep_clear_flush_young(vma, address, pte))
+	if (ptep_clear_flush_young(vma, address, pte) |
+	    mmu_notifier_age_page(mm, address))
 		referenced++;
 
 	/* Pretend the page is referenced if the task has the
@@ -434,6 +436,7 @@ static int page_mkclean_one(struct page 
 
 		flush_cache_page(vma, address, pte_pfn(*pte));
 		entry = ptep_clear_flush(vma, address, pte);
+		mmu_notifier(invalidate_page, mm, address);
 		entry = pte_wrprotect(entry);
 		entry = pte_mkclean(entry);
 		set_pte_at(mm, address, pte, entry);
@@ -473,6 +476,10 @@ int page_mkclean(struct page *page)
 		struct address_space *mapping = page_mapping(page);
 		if (mapping) {
 			ret = page_mkclean_file(mapping, page);
+			if (unlikely(PageExternalRmap(page))) {
+				mmu_rmap_notifier(invalidate_page, page);
+				ClearPageExternalRmap(page);
+			}
 			if (page_test_dirty(page)) {
 				page_clear_dirty(page);
 				ret = 1;
@@ -677,7 +684,8 @@ static int try_to_unmap_one(struct page 
 	 * skipped over this mm) then we should reactivate it.
 	 */
 	if (!migration && ((vma->vm_flags & VM_LOCKED) ||
-			(ptep_clear_flush_young(vma, address, pte)))) {
+			(ptep_clear_flush_young(vma, address, pte) |
+				mmu_notifier_age_page(mm, address)))) {
 		ret = SWAP_FAIL;
 		goto out_unmap;
 	}
@@ -685,6 +693,7 @@ static int try_to_unmap_one(struct page 
 	/* Nuke the page table entry. */
 	flush_cache_page(vma, address, page_to_pfn(page));
 	pteval = ptep_clear_flush(vma, address, pte);
+	mmu_notifier(invalidate_page, mm, address);
 
 	/* Move the dirty bit to the physical page now the pte is gone. */
 	if (pte_dirty(pteval))
@@ -809,12 +818,14 @@ static void try_to_unmap_cluster(unsigne
 		page = vm_normal_page(vma, address, *pte);
 		BUG_ON(!page || PageAnon(page));
 
-		if (ptep_clear_flush_young(vma, address, pte))
+		if (ptep_clear_flush_young(vma, address, pte) |
+		    mmu_notifier_age_page(mm, address))
 			continue;
 
 		/* Nuke the page table entry. */
 		flush_cache_page(vma, address, pte_pfn(*pte));
 		pteval = ptep_clear_flush(vma, address, pte);
+		mmu_notifier(invalidate_page, mm, address);
 
 		/* If nonlinear, store the file page offset in the pte. */
 		if (page->index != linear_page_index(vma, address))
@@ -971,6 +982,11 @@ int try_to_unmap(struct page *page, int 
 	else
 		ret = try_to_unmap_file(page, migration);
 
+	if (unlikely(PageExternalRmap(page))) {
+		mmu_rmap_notifier(invalidate_page, page);
+		ClearPageExternalRmap(page);
+	}
+
 	if (!page_mapped(page))
 		ret = SWAP_SUCCESS;
 	return ret;

-- 

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  parent reply	other threads:[~2008-01-31  4:58 UTC|newest]

Thread overview: 181+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-31  4:57 [patch 0/3] [RFC] MMU Notifiers V4 Christoph Lameter
2008-01-31  4:57 ` Christoph Lameter
2008-01-31  4:57 ` [patch 1/3] mmu_notifier: Core code Christoph Lameter
2008-01-31  4:57   ` Christoph Lameter
2008-02-01  1:56   ` Jack Steiner
2008-02-01  1:56     ` Jack Steiner
2008-02-01  1:56     ` Jack Steiner
2008-02-01  2:24     ` Robin Holt
2008-02-01  2:24       ` Robin Holt
2008-02-01  2:24       ` Robin Holt
2008-02-01  2:37       ` Jack Steiner
2008-02-01  2:37         ` Jack Steiner
2008-02-01  2:37         ` Jack Steiner
2008-02-01  2:39         ` Christoph Lameter
2008-02-01  2:39           ` Christoph Lameter
2008-02-01  2:39           ` Christoph Lameter
2008-02-01  2:31   ` Robin Holt
2008-02-01  2:31     ` Robin Holt
2008-02-01  2:31     ` Robin Holt
2008-02-01  2:39     ` Christoph Lameter
2008-02-01  2:39       ` Christoph Lameter
2008-02-01  2:39       ` Christoph Lameter
2008-02-01  2:47       ` Robin Holt
2008-02-01  2:47         ` Robin Holt
2008-02-01  2:47         ` Robin Holt
2008-02-01  3:01         ` Christoph Lameter
2008-02-01  3:01           ` Christoph Lameter
2008-02-01  3:01           ` Christoph Lameter
2008-02-01  3:01       ` Jack Steiner
2008-02-01  3:01         ` Jack Steiner
2008-02-01  3:01         ` Jack Steiner
2008-02-01  3:03         ` Christoph Lameter
2008-02-01  3:03           ` Christoph Lameter
2008-02-01  3:03           ` Christoph Lameter
2008-02-01  3:52   ` Robin Holt
2008-02-01  3:52     ` Robin Holt
2008-02-01  3:52     ` Robin Holt
2008-02-01  3:58     ` Christoph Lameter
2008-02-01  3:58       ` Christoph Lameter
2008-02-01  3:58       ` Christoph Lameter
2008-02-01  4:15       ` Robin Holt
2008-02-01  4:15         ` Robin Holt
2008-02-01  4:15         ` Robin Holt
2008-02-03  1:33       ` Andrea Arcangeli
2008-02-03  1:33         ` Andrea Arcangeli
2008-02-03  1:33         ` Andrea Arcangeli
2008-02-04 19:13         ` Christoph Lameter
2008-02-04 19:13           ` Christoph Lameter
2008-02-04 19:13           ` Christoph Lameter
2008-01-31  4:57 ` [patch 2/3] mmu_notifier: Callbacks to invalidate address ranges Christoph Lameter
2008-01-31  4:57   ` Christoph Lameter
2008-01-31 12:31   ` Andrea Arcangeli
2008-01-31 12:31     ` Andrea Arcangeli
2008-01-31 12:31     ` Andrea Arcangeli
2008-01-31 20:07     ` Christoph Lameter
2008-01-31 20:07       ` Christoph Lameter
2008-01-31 20:07       ` Christoph Lameter
2008-01-31 22:01     ` mmu_notifier: close hole in fork Christoph Lameter
2008-01-31 22:01       ` Christoph Lameter
2008-01-31 22:01       ` Christoph Lameter
2008-01-31 22:16       ` mmu_notifier: reduce size of mm_struct if !CONFIG_MMU_NOTIFIER Christoph Lameter
2008-01-31 22:16         ` Christoph Lameter
2008-01-31 22:16         ` Christoph Lameter
2008-01-31 22:21       ` mmu_notifier: Move mmu_notifier_release up to get rid of the invalidat_all() callback Christoph Lameter
2008-01-31 22:21         ` Christoph Lameter
2008-01-31 22:21         ` Christoph Lameter
2008-02-01  0:13         ` Andrea Arcangeli
2008-02-01  0:13           ` Andrea Arcangeli
2008-02-01  0:13           ` Andrea Arcangeli
2008-02-01  1:52           ` Christoph Lameter
2008-02-01  1:52             ` Christoph Lameter
2008-02-01  1:52             ` Christoph Lameter
2008-02-01  1:57           ` mmu_notifier: invalidate_range for move_page_tables Christoph Lameter
2008-02-01  1:57             ` Christoph Lameter
2008-02-01  1:57             ` Christoph Lameter
2008-02-01  2:38             ` Robin Holt
2008-02-01  2:38               ` Robin Holt
2008-02-01  2:38               ` Robin Holt
2008-02-01  2:41               ` Christoph Lameter
2008-02-01  2:41                 ` Christoph Lameter
2008-02-01  2:41                 ` Christoph Lameter
2008-02-01  0:01       ` mmu_notifier: close hole in fork Andrea Arcangeli
2008-02-01  0:01         ` Andrea Arcangeli
2008-02-01  0:01         ` Andrea Arcangeli
2008-02-01  1:48         ` Christoph Lameter
2008-02-01  1:48           ` Christoph Lameter
2008-02-01  1:48           ` Christoph Lameter
2008-02-01  4:24   ` [patch 2/3] mmu_notifier: Callbacks to invalidate address ranges Robin Holt
2008-02-01  4:24     ` Robin Holt
2008-02-01  4:24     ` Robin Holt
2008-02-01  4:43     ` Christoph Lameter
2008-02-01  4:43       ` Christoph Lameter
2008-02-01  4:43       ` Christoph Lameter
2008-02-01 10:32       ` Robin Holt
2008-02-01 10:32         ` Robin Holt
2008-02-01 10:32         ` Robin Holt
2008-02-01 10:37         ` Robin Holt
2008-02-01 10:37           ` Robin Holt
2008-02-01 19:13         ` Christoph Lameter
2008-02-01 19:13           ` Christoph Lameter
2008-02-01 19:13           ` Christoph Lameter
2008-01-31  4:57 ` Christoph Lameter [this message]
2008-01-31  4:57   ` [patch 3/3] mmu_notifier: invalidate_page callbacks Christoph Lameter
2008-01-31 17:18 ` [PATCH] mmu notifiers #v5 Andrea Arcangeli
2008-01-31 17:18   ` Andrea Arcangeli
2008-01-31 17:18   ` Andrea Arcangeli
2008-01-31 20:18   ` Christoph Lameter
2008-01-31 20:18     ` Christoph Lameter
2008-01-31 20:18     ` Christoph Lameter
2008-01-31 23:09     ` Christoph Lameter
2008-01-31 23:09       ` Christoph Lameter
2008-01-31 23:41       ` Andrea Arcangeli
2008-01-31 23:41         ` Andrea Arcangeli
2008-01-31 23:41         ` Andrea Arcangeli
2008-02-01  1:44         ` Christoph Lameter
2008-02-01  1:44           ` Christoph Lameter
2008-02-01  1:44           ` Christoph Lameter
2008-02-01 12:09           ` Andrea Arcangeli
2008-02-01 12:09             ` Andrea Arcangeli
2008-02-01 12:09             ` Andrea Arcangeli
2008-02-01 19:23             ` Christoph Lameter
2008-02-01 19:23               ` Christoph Lameter
2008-02-01 19:23               ` Christoph Lameter
2008-02-03  2:17               ` Andrea Arcangeli
2008-02-03  2:17                 ` Andrea Arcangeli
2008-02-03  2:17                 ` Andrea Arcangeli
2008-02-03  3:14                 ` Jack Steiner
2008-02-03  3:14                   ` Jack Steiner
2008-02-03  3:14                   ` Jack Steiner
2008-02-03  3:33                   ` Andrea Arcangeli
2008-02-03  3:33                     ` Andrea Arcangeli
2008-02-03  3:33                     ` Andrea Arcangeli
2008-02-04 19:09                 ` Christoph Lameter
2008-02-04 19:09                   ` Christoph Lameter
2008-02-04 19:09                   ` Christoph Lameter
2008-02-05  5:25                   ` Andrea Arcangeli
2008-02-05  5:25                     ` Andrea Arcangeli
2008-02-05  6:11                     ` Christoph Lameter
2008-02-05  6:11                       ` Christoph Lameter
2008-02-05  6:11                       ` Christoph Lameter
2008-02-05 18:08                       ` Andrea Arcangeli
2008-02-05 18:08                         ` Andrea Arcangeli
2008-02-05 18:08                         ` Andrea Arcangeli
2008-02-05 18:17                         ` Christoph Lameter
2008-02-05 18:17                           ` Christoph Lameter
2008-02-05 18:17                           ` Christoph Lameter
2008-02-05 20:55                           ` Andrea Arcangeli
2008-02-05 20:55                             ` Andrea Arcangeli
2008-02-05 20:55                             ` Andrea Arcangeli
2008-02-05 22:06                             ` Christoph Lameter
2008-02-05 22:06                               ` Christoph Lameter
2008-02-05 22:06                               ` Christoph Lameter
2008-02-05 22:12                               ` Robin Holt
2008-02-05 22:12                                 ` Robin Holt
2008-02-05 22:12                                 ` Robin Holt
2008-02-05 22:26                               ` Andrea Arcangeli
2008-02-05 22:26                                 ` Andrea Arcangeli
2008-02-05 22:26                                 ` Andrea Arcangeli
2008-02-05 23:10                                 ` Christoph Lameter
2008-02-05 23:10                                   ` Christoph Lameter
2008-02-05 23:10                                   ` Christoph Lameter
2008-02-05 23:47                                   ` Andrea Arcangeli
2008-02-05 23:47                                     ` Andrea Arcangeli
2008-02-05 23:47                                     ` Andrea Arcangeli
2008-02-06  0:04                                     ` Christoph Lameter
2008-02-06  0:04                                       ` Christoph Lameter
2008-02-06  0:04                                       ` Christoph Lameter
2008-01-31 23:28     ` Andrea Arcangeli
2008-01-31 23:28       ` Andrea Arcangeli
2008-02-01  1:37       ` Christoph Lameter
2008-02-01  1:37         ` Christoph Lameter
2008-02-01  1:37         ` Christoph Lameter
2008-02-01  2:23         ` Robin Holt
2008-02-01  2:23           ` Robin Holt
2008-02-01  2:23           ` Robin Holt
2008-02-01  2:26           ` Christoph Lameter
2008-02-01  2:26             ` Christoph Lameter
2008-02-01  2:26             ` Christoph Lameter
2008-02-01 12:00         ` Andrea Arcangeli
2008-02-01 12:00           ` Andrea Arcangeli
2008-02-01 12:00           ` Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080131045813.016961450@sgi.com \
    --to=clameter@sgi.com \
    --cc=andrea@qumranet.com \
    --cc=avi@qumranet.com \
    --cc=holt@sgi.com \
    --cc=izike@qumranet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.